Update Color Splasher

#2626 (comment)

Color Splasher - line 131 DB.ElementId.InvalidElementId (in versions 2024 and earlier) this is ignored and keep default, I get exception thrown for 2025 and 2026, since I don't think we need to change the line pattern, I am proposing to eliminate this line.

Color Splasher - Filter Name separator between cat and param name, added a space in line 364

Color Splasher - Create Legend not working, Fixed the conditional statement,

Author: tay0thman

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/ColorSplasher.pushbutton/script.py

@@ -128,7 +128,7 @@ def Execute(self, uiapp):
                     if solid_fill_id is not None:
                         ogs.SetSurfaceForegroundPatternId(solid_fill_id)
                         ogs.SetCutForegroundPatternId(solid_fill_id)
-                    ogs.SetProjectionLinePatternId(DB.ElementId(-1))
+                        
                     for idt in wndw.list_box2.Items[indx]['Value'].ele_id:
                         view.SetElementOverrides(idt, ogs)
         except Exception:
@@ -197,7 +197,7 @@ def Execute(self, uiapp):
                 if vw.ViewType == DB.ViewType.Legend:
                     legends.append(vw)
                     break
-            if len(legends) < 0:
+            if len(legends) = 0:
                 task2 = UI.TaskDialog("Color Elements by Parameter")
                 task2.MainInstruction = "In order to create a new legend, you need to have at least one. Please, create a legend view."
                 wndw.TopMost = False
@@ -361,7 +361,7 @@ def Execute(self, uiapp):
                         ogs.SetSurfaceForegroundPatternId(solid_fill_id)
                         ogs.SetCutForegroundPatternId(solid_fill_id)
                         # Get filters apply to view
-                        filter_name = sel_cat.name + "/" + sel_par.name + " - " + item.value
+                        filter_name = sel_cat.name + " " + sel_par.name + " - " + item.value
                         # added ':' character and chaged the removal method to translate, ref: issue #2466
                         filter_name = filter_name.translate({ord(i): None for i in "{}[]:\\|?/<>*"})
                         if filter_name in dict_filters or filter_name in dict_rules: