pylint: update to 1.8.1

Author: pyroscope

requirements-dev.txt

@@ -3,7 +3,7 @@ Paver==1.2.4
 Tempita==0.5.2
 epydoc==3.0.1
 bpython==0.16
-pylint==1.5.6
+pylint==1.8.1
 tox==2.9.1
 mock==2.0.0
 twine==1.9.1

src/pyrobase/bencode.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# pylint: disable=too-few-public-methods
+# pylint: disable=too-few-public-methods,invalid-name
 """ Bencode support.
 
     Copyright (c) 2009-2017 The PyroScope Project <[email protected]>
@@ -87,7 +87,7 @@ def decode(self, check_trailer=False): # pylint: disable=I0011,R0912
         elif kind == 'l':
             # List
             self.offset += 1
-            obj = []  # pylint: disable=redefined-variable-type
+            obj = []
             while self.data[self.offset:self.offset+1] != 'e':
                 obj.append(self.decode())
             self.offset += 1

src/pyrobase/fmt.py

@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+# pylint: disable=invalid-name,no-else-return
 """ Data Formatting.
 
     Copyright (c) 2009, 2011 The PyroScope Project <[email protected]>

src/pyrobase/io/xmlrpc2scgi.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# pylint: disable=too-few-public-methods
+# pylint: disable=too-few-public-methods,no-else-return
 """ XMLRPC via SCGI client proxy over various transports.
 
     Copyright (c) 2011 The PyroScope Project <[email protected]>
@@ -162,7 +162,7 @@ def transport_from_url(url):
     """
     if '/' not in url and ':' in url and url.rsplit(':')[-1].isdigit():
         url = 'scgi://' + url
-    url = urlparse.urlsplit(url, "scgi", allow_fragments=False)
+    url = urlparse.urlsplit(url, scheme="scgi", allow_fragments=False)  # pylint: disable=redundant-keyword-arg
 
     try:
         transport = TRANSPORTS[url.scheme.lower()]

src/pyrobase/paver/quality.py

@@ -36,8 +36,6 @@
 @support.task_requires("pylint>=1.4")
 def lint():
     "report pylint results"
-    from pylint import lint as linter # pylint: disable=W0404
-
     # report according to file extension
     report_formats = {
         ".html": "html",

src/pyrobase/paver/support.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# pylint: disable=
+# pylint: disable=no-else-return
 """ Paver Task Implementation Helpers.
 
     Copyright (c) 2011 The PyroScope Project <[email protected]>
@@ -25,7 +25,7 @@
 from pyrobase import iterutil
 
 
-def venv_bin(name=None):
+def venv_bin(name=None):  # pylint: disable=inconsistent-return-statements
     """ Get the directory for virtualenv stubs, or a full executable path
         if C{name} is provided.
     """

src/pyrobase/templating.py

@@ -91,7 +91,7 @@ def preparse(template_text, lookup=None):
             template = tempita.Template(template_text, name=template_path)
             template.__engine__ = "tempita"
         else:
-            template = InterpolationTemplate(template_text)  # pylint: disable=redefined-variable-type
+            template = InterpolationTemplate(template_text)
 
         template.__file__ = template_path
 

src/pyrobase/testing.py

@@ -16,6 +16,8 @@
 # You should have received a copy of the GNU General Public License along
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+from __future__ import absolute_import, print_function, unicode_literals
+
 import errno
 from contextlib import contextmanager
 
@@ -71,5 +73,5 @@ def mock_open(name, mode=None, buffering=None): # pylint: disable=W0613
         else:
             return DictItemIO(fakefiles, name)
 
-    with mock.patch("__builtin__.open" if PY2 else "builtins.open", mock_open) as mock_file:
+    with mock.patch("__builtin__.open" if PY2 else "builtins.open", mock_open):
         yield fakefiles

src/pyrobase/webservice/imgur.py

@@ -35,8 +35,7 @@
     raise ImportError("Please 'pip install \"pyrobase[imgur]\"' (%s)" % (_exc,))
 from imgurpython.helpers.error import ImgurClientError, ImgurClientRateLimitError
 
-from pyrobase import parts, pyutil, logutil, fmt
-from pyrobase.io import http
+from pyrobase import parts, pyutil
 
 json = pyutil.require_json()
 LOG = logging.getLogger(__name__)
@@ -98,7 +97,8 @@ def upload(self, image, name=None):
         # Upload image
         # XXX "name",    name or hashlib.md5(str(image)).hexdigest()),
         client = ImgurClient(self.client_id, self.client_secret)
-        result = (client.upload_from_url if image_type == 'url' else client.upload_from_path)(image_data)  # XXX config=None, anon=True)
+        result = (client.upload_from_url if image_type == 'url'
+                  else client.upload_from_path)(image_data)  # XXX config=None, anon=True)
 
         if result['link'].startswith('http:'):
             result['link'] = 'https:' + result['link'][5:]