Skip to content

Commit e5bcda1

Browse files
author
Serge Rey
committed
Do not poll on init
1 parent ea86611 commit e5bcda1

File tree

2 files changed

+26
-16
lines changed

2 files changed

+26
-16
lines changed

libpysal/examples/__init__.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,30 @@
44

55
from .base import example_manager
66
from .remotes import datasets as remote_datasets
7-
from .remotes import download as fetch_all
87
from .builtin import datasets as builtin_datasets
98

109

1110
from typing import Union
1211

1312
__all__ = ["get_path", "available", "explain", "fetch_all"]
1413

15-
example_manager.add_examples(remote_datasets)
1614
example_manager.add_examples(builtin_datasets)
1715

16+
def fetch_all():
17+
"""Fetch and install all remote datasets
18+
"""
19+
datasets = remote_datasets.datasets
20+
names = list(datasets.keys())
21+
names.sort()
22+
for name in names:
23+
print(name)
24+
example = datasets[name]
25+
try:
26+
example.download()
27+
except:
28+
print("Example not downloaded: {}".format(name))
29+
example_manager.add_examples(datasets)
30+
1831

1932
def available() -> str:
2033
"""List available datasets."""

libpysal/examples/remotes.py

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,17 @@ def poll_remotes():
9595
return datasets
9696

9797

98-
datasets = poll_remotes()
98+
#datasets = poll_remotes()
9999

100+
class Remotes:
101+
def __init__(self):
102+
self._datasets = None
100103

101-
def download(datasets=datasets):
102-
"""
103-
Download all known remotes
104-
"""
104+
@property
105+
def datasets(self):
106+
if self._datasets is None:
107+
self._datasets = poll_remotes()
108+
return self._datasets
109+
110+
datasets = Remotes()
105111

106-
names = list(datasets.keys())
107-
names.sort()
108-
for name in names:
109-
print(name)
110-
example = datasets[name]
111-
try:
112-
example.download()
113-
except:
114-
print("Example not downloaded: {}".format(name))

0 commit comments

Comments
 (0)