Merge pull request #33 from pyscript/better-dispatch

Better dispatch with id check

Author: WebReflection

core.js.map

@@ -17,8 +17,15 @@ const nodeInfo = (node, type) => ({
     tag: node.tagName
 });
 
+/**
+ * Notify the main thread about element "readiness".
+ * @param {HTMLScriptElement | HTMLElement} target the script or custom-type element
+ * @param {string} type the custom/type as event prefix
+ * @param {boolean} worker `true` if dispatched form a worker, `false` if in main
+ * @param {globalThis.CustomEvent} CustomEvent the right global to use
+ */
 const dispatch = (target, type, worker, CustomEvent) => {
-    if (target) target.dispatchEvent(
+    target.dispatchEvent(
         new CustomEvent(`${type}:ready`, {
             bubbles: true,
             detail: { worker },

docs/core.js

@@ -99,15 +99,15 @@ add('message', ({ data: { options, config: baseURL, code, hooks } }) => {
             }
 
             const { CustomEvent, document } = window;
-            const element = document.getElementById(id);
+            const element = id && document.getElementById(id) || null;
 
             let target = '';
 
             // set the `xworker` global reference once
             details.registerJSModule(interpreter, 'polyscript', {
                 xworker,
                 get target() {
-                    if (!target) {
+                    if (!target && element) {
                         if (tag === 'SCRIPT') {
                             element.after(assign(
                                 document.createElement(`script-${custom || type}`),
@@ -130,7 +130,7 @@ add('message', ({ data: { options, config: baseURL, code, hooks } }) => {
             // allows transforming arguments with sync
             transform = details.transform.bind(details, interpreter);
 
-            dispatch(element, custom || type, true, CustomEvent);
+            if (element) dispatch(element, custom || type, true, CustomEvent);
 
             // run either sync or async code in the worker
             await details[name](interpreter, code);

docs/core.js.map

@@ -1,6 +1,6 @@
 {
     "name": "polyscript",
-    "version": "0.3.4",
+    "version": "0.3.5",
     "description": "PyScript single core to rule them all",
     "main": "./cjs/index.js",
     "types": "./types/polyscript/esm/index.d.ts",
@@ -67,9 +67,9 @@
         "@ungap/with-resolvers": "^0.1.0",
         "basic-devtools": "^0.1.6",
         "codedent": "^0.1.2",
-        "coincident": "^0.11.5"
+        "coincident": "^0.11.6"
     },
     "worker": {
-        "blob": "sha256-DIHUuInfI4tdn+DpgcTAEaslvvsvwq51ZU18P3a6bnk="
+        "blob": "sha256-YCjLBQpKRjsu6QAzGWRouTXHL9/8bvDnOFrZ2RIb6lM="
     }
 }