Follow up for src / worker validation

Author: WebReflection

core.js.map

@@ -1,13 +1,19 @@
 import { dedent } from '../utils.js';
 
+const hasCommentsOnly = text => !text
+    .replace(/\/\*[\s\S]*?\*\//g, '')
+    .replace(/^\s*(?:\/\/|#).*/gm, '')
+    .trim()
+;
+
 /* c8 ignore start */ // tested via integration
 export default element => {
   const { src, worker } = element.attributes;
   if (worker) {
       let { value } = worker;
       // throw on worker values as ambiguous
       // @see https://github.com/pyscript/polyscript/issues/43
-      if (value) throw new SyntaxError(`Invalid worker attribute: ${value}`);
+      if (value) throw new SyntaxError('Invalid worker attribute');
       value = src?.value;
       if (!value) {
           // throw on empty src attributes
@@ -32,5 +38,8 @@ export default element => {
       }
       return value;
   }
+  // validate ambiguous cases with src and not empty/commented content
+  if (src && !hasCommentsOnly(element.textContent))
+    throw new SyntaxError('Invalid content');
 };
 /* c8 ignore stop */

docs/core.js

@@ -114,6 +114,6 @@ exports.python = {
         page.on('console', msg => logs.push(msg.text()));
         await page.goto(url);
         await page.waitForSelector('html.error');
-        await expect(logs.pop()).toBe('Invalid worker attribute: nope.py');
+        await expect(logs.pop()).toBe('Invalid worker attribute');
     },
 };