Skip to content

Commit cf04a39

Browse files
workaround global finder bug when nested functions and imports are in play
1 parent ac6f642 commit cf04a39

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/execnet/gateway.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ def _source_of_function(function):
211211
source = textwrap.dedent(source) # just for inner functions
212212

213213
used_globals = _find_non_builtin_globals(source, codeobj)
214-
if used_globals:
214+
if used_globals and False:
215+
# disabled this check as it fails for more complex examples
215216
raise ValueError("the use of non-builtin globals isn't supported", used_globals)
216217

217218
leading_ws = "\n" * (codeobj.co_firstlineno - 1)

testing/test_basics.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,7 @@ def f():
397397

398398
assert self.check(f) == []
399399

400+
@pytest.mark.xfail(reason="test disabled due to bugs")
400401
def test_function_with_global_fails(self):
401402
def func(channel):
402403
sys

0 commit comments

Comments
 (0)