Remove legacy HookimplOpts normalization and from_opts method

- Remove normalize_hookimpl_opts function as modern pluggy uses HookimplConfiguration directly
- Remove HookimplConfiguration.from_opts class method (backward compatibility no longer needed)
- Simplify _parse_hookimpl method by removing dict-based configuration handling
- Use HookimplConfiguration constructor directly instead of factory method
- Maintain compatibility with parse_hookimpl_opts override for subclasses like pytest
- Remove unnecessary normalize_hookimpl_opts import from _manager.py

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: RonnyPfannschmidt

src/pluggy/_hooks.py

@@ -137,11 +137,6 @@ def __init__(
         #: The name of the hook specification to match, see :ref:`specname`.
         self.specname: Final = specname
 
-    @classmethod
-    def from_opts(cls, opts: HookimplOpts) -> HookimplConfiguration:
-        """Create from HookimplOpts for backward compatibility."""
-        return cls(**opts)
-
     def __repr__(self) -> str:
         attrs = []
         for slot in self.__slots__:
@@ -385,15 +380,6 @@ def get_hookconfig(self, func: Callable[..., object]) -> HookimplConfiguration:
         return config
 
 
-def normalize_hookimpl_opts(opts: HookimplOpts) -> None:
-    opts.setdefault("tryfirst", False)
-    opts.setdefault("trylast", False)
-    opts.setdefault("wrapper", False)
-    opts.setdefault("hookwrapper", False)
-    opts.setdefault("optionalhook", False)
-    opts.setdefault("specname", None)
-
-
 _PYPY = hasattr(sys, "pypy_version_info")
 
 

src/pluggy/_manager.py

@@ -25,7 +25,6 @@
 from ._hooks import HookimplOpts
 from ._hooks import HookRelay
 from ._hooks import HookspecOpts
-from ._hooks import normalize_hookimpl_opts
 from ._result import Result
 
 
@@ -185,9 +184,6 @@ def _parse_hookimpl(
     ) -> HookimplConfiguration | None:
         """Internal method to parse hook implementation configuration.
 
-        This method uses the new HookimplConfiguration type internally.
-        Falls back to the legacy parse_hookimpl_opts method for compatibility.
-
         :param plugin: The plugin object to inspect
         :param name: The attribute name to check for hook implementation
         :returns: HookimplConfiguration if found, None otherwise
@@ -201,25 +197,19 @@ def _parse_hookimpl(
             return None
 
         try:
-            # Try to get hook implementation configuration directly
+            # Get hook implementation configuration directly
             impl_attr = getattr(method, self.project_name + "_impl", None)
         except Exception:  # pragma: no cover
             impl_attr = None
 
-        if impl_attr is not None:
-            # Check if it's already a HookimplConfiguration (new style)
-            if isinstance(impl_attr, HookimplConfiguration):
-                return impl_attr
-            # Handle legacy dict-based configuration
-            elif isinstance(impl_attr, dict):
-                return HookimplConfiguration.from_opts(impl_attr)  # type: ignore
+        if isinstance(impl_attr, HookimplConfiguration):
+            return impl_attr
 
         # Fall back to legacy parse_hookimpl_opts for compatibility
         # (e.g. pytest override)
         legacy_opts = self.parse_hookimpl_opts(plugin, name)
         if legacy_opts is not None:
-            normalize_hookimpl_opts(legacy_opts)
-            return HookimplConfiguration.from_opts(legacy_opts)
+            return HookimplConfiguration(**legacy_opts)
 
         return None