Add non-functional argument "effective_ids" to "os.access()"`

- fixes #585

Author: mrbean-bremen

CHANGES.md

@@ -12,7 +12,9 @@ The released versions correspond to PyPi releases.
 ### Fixes
   * fixed handling of pipe descriptors in the fake filesystem 
     (see [#581](../../issues/581))
-    
+  * added non-functional argument `effective_ids` to `os.access`
+    (see [#585](../../issues/585))
+      
 ### Infrastructure
   * added automatic documentation build and check-in
 

pyfakefs/fake_filesystem.py

@@ -4282,7 +4282,8 @@ def ftruncate(self, fd, length):
         file_object = self.filesystem.get_open_file(fd).get_object()
         file_object.size = length
 
-    def access(self, path, mode, *, dir_fd=None, follow_symlinks=True):
+    def access(self, path, mode, *, dir_fd=None, effective_ids=False,
+               follow_symlinks=True):
         """Check if a file exists and has the specified permissions.
 
         Args:
@@ -4291,12 +4292,16 @@ def access(self, path, mode, *, dir_fd=None, follow_symlinks=True):
                 os.F_OK, os.R_OK, os.W_OK, and os.X_OK.
             dir_fd: If not `None`, the file descriptor of a directory, with
                 `path` being relative to this directory.
+            effective_ids: (bool) Unused. Only here to match the signature.
             follow_symlinks: (bool) If `False` and `path` points to a symlink,
                 the link itself is queried instead of the linked object.
 
         Returns:
             bool, `True` if file is accessible, `False` otherwise.
         """
+        if effective_ids and self.filesystem.is_windows_fs:
+            raise NotImplementedError(
+                'access: effective_ids unavailable on this platform')
         path = self._path_with_dir_fd(path, self.access, dir_fd)
         try:
             stat_result = self.stat(path, follow_symlinks=follow_symlinks)

pyfakefs/tests/fake_os_test.py

@@ -1896,6 +1896,12 @@ def test_access_non_existent_file(self):
         self.assertFalse(self.os.access(path, self.rwx))
         self.assertFalse(self.os.access(path, self.rw))
 
+    def test_effective_ids_not_supported_under_windows(self):
+        self.check_windows_only()
+        path = self.make_path('foo', 'bar')
+        with self.assertRaises(NotImplementedError):
+            self.os.access(path, self.os.F_OK, effective_ids=True)
+
     def test_chmod(self):
         # set up
         self.check_posix_only()