Add verify base URL timeouts (#4)

Fixes #3

Author: b4handjr

pytest_base_url/plugin.py

@@ -6,6 +6,8 @@
 
 import pytest
 import requests
+from requests.packages.urllib3.util.retry import Retry
+from requests.adapters import HTTPAdapter
 
 
 @pytest.fixture(scope='session')
@@ -22,12 +24,11 @@ def _verify_url(request, base_url):
     """Verifies the base URL"""
     verify = request.config.option.verify_base_url
     if base_url and verify:
-        response = requests.get(base_url, timeout=10)
-        if not response.status_code == requests.codes.ok:
-            raise pytest.UsageError(
-                'Base URL failed verification!'
-                '\nURL: {0}, Response status code: {1.status_code}'
-                '\nResponse headers: {1.headers}'.format(base_url, response))
+        session = requests.Session()
+        retries = Retry(backoff_factor=0.1,
+                        status_forcelist=[500, 502, 503, 504])
+        session.mount(base_url, HTTPAdapter(max_retries=retries))
+        session.get(base_url)
 
 
 def pytest_configure(config):

tests/test_verify_base_url.py

@@ -3,6 +3,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import pytest
+from requests.packages.urllib3.util.retry import Retry
 
 
 @pytest.fixture(autouse=True)
@@ -20,32 +21,32 @@ def test_ignore_bad_url_by_default(testdir, httpserver):
 def test_enable_verify_via_cli(testdir, httpserver, monkeypatch):
     testdir.makepyfile('def test_pass(): pass')
     monkeypatch.setenv('VERIFY_BASE_URL', False)
+    monkeypatch.setattr(Retry, 'BACKOFF_MAX', 0.5)
     status_code = 500
     httpserver.serve_content(content='<h1>Error!</h1>', code=status_code)
     reprec = testdir.inline_run('--base-url', httpserver.url,
                                 '--verify-base-url')
     passed, skipped, failed = reprec.listoutcomes()
     assert len(failed) == 1
     out = failed[0].longrepr.reprcrash.message
-    assert 'UsageError: Base URL failed verification!' in out
-    assert 'URL: {0}'.format(httpserver.url) in out
-    assert 'Response status code: {0}'.format(status_code) in out
-    assert 'Response headers: ' in out
+    assert 'Max retries exceeded with url:' in out
+    assert 'Caused by ResponseError' in out
+    assert 'too many 500 error responses' in out
 
 
 def test_enable_verify_via_env(testdir, httpserver, monkeypatch):
     testdir.makepyfile('def test_pass(): pass')
     monkeypatch.setenv('VERIFY_BASE_URL', True)
+    monkeypatch.setattr(Retry, 'BACKOFF_MAX', 0.5)
     status_code = 500
     httpserver.serve_content(content='<h1>Error!</h1>', code=status_code)
     reprec = testdir.inline_run('--base-url', httpserver.url)
     passed, skipped, failed = reprec.listoutcomes()
     assert len(failed) == 1
     out = failed[0].longrepr.reprcrash.message
-    assert 'UsageError: Base URL failed verification!' in out
-    assert 'URL: {0}'.format(httpserver.url) in out
-    assert 'Response status code: {0}'.format(status_code) in out
-    assert 'Response headers: ' in out
+    assert 'Max retries exceeded with url:' in out
+    assert 'Caused by ResponseError' in out
+    assert 'too many 500 error responses' in out
 
 
 def test_disable_verify_via_env(testdir, httpserver, monkeypatch):
@@ -54,3 +55,17 @@ def test_disable_verify_via_env(testdir, httpserver, monkeypatch):
     httpserver.serve_content(content='<h1>Error!</h1>', code=500)
     result = testdir.runpytest('--base-url', httpserver.url)
     assert result.ret == 0
+
+
+def test_url_fails(testdir, httpserver, monkeypatch):
+    testdir.makepyfile('def test_pass(): pass')
+    monkeypatch.setenv('VERIFY_BASE_URL', False)
+    monkeypatch.setattr(Retry, 'BACKOFF_MAX', 0.5)
+    reprec = testdir.inline_run('--base-url', 'http://foo',
+                                '--verify-base-url')
+    passed, skipped, failed = reprec.listoutcomes()
+    out = failed[0].longrepr.reprcrash.message
+    assert len(failed) == 1
+    assert 'Max retries exceeded with url:' in out
+    assert 'Caused by NewConnectionError' in out
+    assert 'Failed to establish a new connection' in out