cast "values" as a string because it could be another type if using e… (#335)

* cast "values" as a string because it could be another type if using example converters

* Test for int string and float value

Co-authored-by: Marc BROSSAIS <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>

Author: 3 people

pytest_bdd/cucumber_json.py

@@ -90,7 +90,7 @@ def _serialize_tags(self, item):
 
     def _format_name(self, name, keys, values):
         for param, value in zip(keys, values):
-            name = name.replace("<{}>".format(param), value)
+            name = name.replace("<{}>".format(param), str(value))
         return name
 
     def _format_step_name(self, report, step):

tests/feature/test_cucumber_json.py

@@ -280,3 +280,55 @@ def test_passing_outline():
     assert jsonobject[0]["elements"][0]["steps"][0]["name"] == "type str and value hello"
     assert jsonobject[0]["elements"][1]["steps"][0]["name"] == "type int and value 42"
     assert jsonobject[0]["elements"][2]["steps"][0]["name"] == "type float and value 1.0"
+
+
+def test_converters_dict_with_expand_option(testdir):
+    """Test step trace."""
+    testdir.makefile(
+        ".ini",
+        pytest=textwrap.dedent(
+            """
+    [pytest]
+    markers =
+        feature-tag
+        scenario-outline-passing-tag
+    """
+        ),
+    )
+    testdir.makefile(
+        ".feature",
+        test=textwrap.dedent(
+            """
+    @feature-tag
+    Feature: One scenario outline, expanded to multiple scenarios
+
+        @scenario-outline-passing-tag
+        Scenario: Passing outline
+            Given intvalue <intvalue> and stringvalue <stringvalue> and floatvalue <floatvalue>
+
+            Examples: example1
+            | intvalue| stringvalue | floatvalue |
+            | 1     | hello  | 1.0 |
+    """
+        ),
+    )
+    testdir.makepyfile(
+        textwrap.dedent(
+            """
+        import pytest
+        from pytest_bdd import given, scenario
+
+        @given('intvalue <intvalue> and stringvalue <stringvalue> and floatvalue <floatvalue>')
+        def type_type_and_value_value():
+            return 'pass'
+
+        @scenario('test.feature', 'Passing outline', example_converters=dict(intvalue=int, stringvalue=str, floatvalue=float))
+        def test_passing_outline():
+            pass
+    """
+        )
+    )
+    result, jsonobject = runandparse(testdir, "--cucumber-json-expanded")
+    assert result.ret == 0
+
+    assert jsonobject[0]["elements"][0]["steps"][0]["name"] == "intvalue 1 and stringvalue hello and floatvalue 1.0"