Response to feedback

Author: jsa34

src/pytest_bdd/generation.py

@@ -62,7 +62,6 @@ def generate_code(features: list[Feature], scenarios: list[ScenarioTemplate], st
     """Generate test code for the given filenames."""
     grouped_steps = group_steps(steps)
     template = template_lookup.get_template("test.py.mak")
-
     code = template.render(
         features=features,
         scenarios=scenarios,
@@ -84,39 +83,42 @@ def show_missing_code(config: Config) -> int:
 def print_missing_code(scenarios: list[ScenarioTemplate], steps: list[Step]) -> None:
     """Print missing code with TerminalWriter."""
     tw = TerminalWriter()
+    scenario = step = None
 
     for scenario in scenarios:
         tw.line()
         tw.line(
-            f'Scenario "{scenario.name}" is not bound to any test in the feature "{scenario.feature.name}"'
-            f" in the file {scenario.feature.filename}:{scenario.line_number}",
+            'Scenario "{scenario.name}" is not bound to any test in the feature "{scenario.feature.name}"'
+            " in the file {scenario.feature.filename}:{scenario.line_number}".format(scenario=scenario),
             red=True,
         )
 
-    tw.sep("-", red=True)
+    if scenario:
+        tw.sep("-", red=True)
 
     for step in steps:
         tw.line()
         if step.scenario is not None:
             tw.line(
-                f"""Step {step} is not defined in the scenario "{step.scenario.name}" in the feature"""
-                f""" "{step.scenario.feature.name}" in the file"""
-                f" {step.scenario.feature.filename}:{step.line_number}",
+                """Step {step} is not defined in the scenario "{step.scenario.name}" in the feature"""
+                """ "{step.scenario.feature.name}" in the file"""
+                """ {step.scenario.feature.filename}:{step.line_number}""".format(step=step),
                 red=True,
             )
         elif step.background is not None:
             tw.line(
-                f"""Step {step} is not defined in the background of the feature"""
-                f""" "{step.background.feature.name}" in the file"""
-                f" {step.background.feature.filename}:{step.line_number}",
+                """Step {step} is not defined in the background of the feature"""
+                """ "{step.background.feature.name}" in the file"""
+                """ {step.background.feature.filename}:{step.line_number}""".format(step=step),
                 red=True,
             )
 
-    tw.sep("-", red=True)
-    tw.line("Please place the code above into the test file(s):")
+    if step:
+        tw.sep("-", red=True)
+
+    tw.line("Please place the code above to the test file(s):")
     tw.line()
 
-    # Group features and generate the test code
     features = sorted(
         (scenario.feature for scenario in scenarios), key=lambda feature: feature.name or feature.filename
     )

src/pytest_bdd/parser.py

@@ -137,7 +137,7 @@ class ScenarioTemplate:
     description: str | None = None
     tags: set[str] = field(default_factory=set)
     _steps: list[Step] = field(init=False, default_factory=list)
-    examples: list[Examples] = field(default_factory=list)
+    examples: list[Examples] | None = field(default_factory=list[Examples])
 
     def add_step(self, step: Step) -> None:
         """Add a step to the scenario.

src/pytest_bdd/scenario.py

@@ -17,12 +17,13 @@
 import logging
 import os
 import re
+import warnings
 from collections.abc import Iterable, Iterator
 from typing import TYPE_CHECKING, Any, Callable, TypeVar, cast
 
 import pytest
 from _pytest.fixtures import FixtureDef, FixtureManager, FixtureRequest, call_fixture_func
-from pytest import PytestUnknownMarkWarning, warns
+from pytest import PytestUnknownMarkWarning
 from typing_extensions import ParamSpec
 
 from . import exceptions
@@ -305,23 +306,20 @@ def collect_example_parametrizations(
     templated_scenario: ScenarioTemplate,
 ) -> list[ParameterSet] | None:
     parametrizations = []
-    has_multiple_examples = len(templated_scenario.examples) > 1
 
-    for example_id, examples in enumerate(templated_scenario.examples):
-        _tags: set = examples.tags or set()
-        example_marks = []
-        if _tags:
-            with warns(PytestUnknownMarkWarning, match=r"Unknown pytest\.mark\.\w+"):
-                example_marks = [pytest.mark.__getattr__(tag) for tag in _tags]
+    for examples in templated_scenario.examples:
+        tags: set = examples.tags or set()
+
+        with warnings.catch_warnings():
+            warnings.filterwarnings("ignore", category=PytestUnknownMarkWarning)
+            example_marks = [getattr(pytest.mark, tag) for tag in tags]
 
         for context in examples.as_contexts() or [{}]:
-            test_id = (
-                "-".join((str(example_id), *context.values())) if has_multiple_examples else "-".join(context.values())
-            )
+            param_id = "-".join(context.values())
             parametrizations.append(
                 pytest.param(
                     context,
-                    id=test_id,
+                    id=param_id,
                     marks=example_marks,
                 ),
             )

tests/feature/test_outline.py

@@ -127,6 +127,11 @@ def test_multiple_outlined(pytester):
         1, 4.0, "-3",
     ]
     # fmt: on
+    result = pytester.runpytest("-k", "positive", "-vv")
+    result.assert_outcomes(passed=2, deselected=2)
+
+    result = pytester.runpytest("-k", "positive or negative", "-vv")
+    result.assert_outcomes(passed=4, deselected=0)
 
 
 def test_unused_params(pytester):

tests/feature/test_tags.py

@@ -226,47 +226,3 @@ def _():
 
     result = pytester.runpytest("-m", "tag2", "-vv")
     result.assert_outcomes(passed=1, deselected=1)
-
-
-def test_tags_against_multiple_examples_tables(pytester):
-    pytester.makefile(
-        ".feature",
-        test="""\
-    Feature: Scenario with tags over multiple lines
-
-        Scenario Outline: Tags
-            Given I have a <item>
-
-        @food
-        Examples: Food
-            | item |
-            | bun  |
-            | ice  |
-
-        @drink
-        Examples: Drinks
-            | item  |
-            | water |
-            | juice |
-    """,
-    )
-    pytester.makepyfile(
-        """
-        from pytest_bdd import given, scenarios, parsers
-
-        scenarios('test.feature')
-
-        @given(parsers.parse('I have a {item}'))
-        def _(item: str):
-            pass
-    """
-    )
-
-    result = pytester.runpytest("-m", "food", "-vv")
-    result.assert_outcomes(passed=2, deselected=2)
-
-    result = pytester.runpytest("-m", "drink", "-vv")
-    result.assert_outcomes(passed=2, deselected=2)
-
-    result = pytester.runpytest("-m", "food or drink", "-vv")
-    result.assert_outcomes(passed=4, deselected=0)

tests/generation/test_generate_missing.py

@@ -84,7 +84,7 @@ def test_missing_steps():
         ['Step Given "I have a foobar" is not defined in the background of the feature "Missing code generation" *']
     )
 
-    result.stdout.fnmatch_lines(["Please place the code above into the test file(s):"])
+    result.stdout.fnmatch_lines(["Please place the code above to the test file(s):"])
 
 
 def test_generate_missing_with_step_parsers(pytester):