test_report_context -> test_report_context_registry

This way we are consistent with the other registries

Author: youtux

src/pytest_bdd/cucumber_json.py

@@ -8,7 +8,7 @@
 import time
 import typing
 
-from .reporting import test_report_context
+from .reporting import test_report_context_registry
 
 if typing.TYPE_CHECKING:
     from typing import Any
@@ -89,7 +89,7 @@ def _serialize_tags(self, item: dict[str, Any]) -> list[dict[str, Any]]:
 
     def pytest_runtest_logreport(self, report: TestReport) -> None:
         try:
-            scenario = test_report_context[report].scenario
+            scenario = test_report_context_registry[report].scenario
         except KeyError:
             # skip reporting for non-bdd tests
             return
@@ -130,7 +130,7 @@ def stepmap(step: dict[str, Any]) -> dict[str, Any]:
         self.features[scenario["feature"]["filename"]]["elements"].append(
             {
                 "keyword": scenario["keyword"],
-                "id": test_report_context[report].name,
+                "id": test_report_context_registry[report].name,
                 "name": scenario["name"],
                 "line": scenario["line_number"],
                 "description": "",

src/pytest_bdd/gherkin_terminal_reporter.py

@@ -4,7 +4,7 @@
 
 from _pytest.terminal import TerminalReporter
 
-from .reporting import test_report_context
+from .reporting import test_report_context_registry
 
 if typing.TYPE_CHECKING:
     from typing import Any
@@ -72,7 +72,7 @@ def pytest_runtest_logreport(self, report: TestReport) -> Any:
         rule_markup = {"purple": True}
 
         try:
-            scenario = test_report_context[report].scenario
+            scenario = test_report_context_registry[report].scenario
         except KeyError:
             scenario = None
 

src/pytest_bdd/reporting.py

@@ -22,7 +22,7 @@
     from .parser import Feature, Scenario, Step
 
 scenario_reports_registry: WeakKeyDictionary[Item, ScenarioReport] = WeakKeyDictionary()
-test_report_context: WeakKeyDictionary[TestReport, ReportContext] = WeakKeyDictionary()
+test_report_context_registry: WeakKeyDictionary[TestReport, ReportContext] = WeakKeyDictionary()
 
 
 class StepReport:
@@ -165,7 +165,7 @@ def runtest_makereport(item: Item, call: CallInfo, rep: TestReport) -> None:
     except KeyError:
         return
 
-    test_report_context[rep] = ReportContext(scenario=scenario_report.serialize(), name=item.name)
+    test_report_context_registry[rep] = ReportContext(scenario=scenario_report.serialize(), name=item.name)
 
 
 def before_scenario(request: FixtureRequest, feature: Feature, scenario: Scenario) -> None:

tests/feature/test_report.py

@@ -5,7 +5,7 @@
 
 import pytest
 
-from pytest_bdd.reporting import test_report_context
+from pytest_bdd.reporting import test_report_context_registry
 
 
 class OfType:
@@ -105,7 +105,7 @@ def _(cucumbers, left):
     result = pytester.inline_run("-vvl")
     assert result.ret
     report = result.matchreport("test_passing", when="call")
-    scenario = test_report_context[report].scenario
+    scenario = test_report_context_registry[report].scenario
     expected = {
         "feature": {
             "description": "",
@@ -144,7 +144,7 @@ def _(cucumbers, left):
     assert scenario == expected
 
     report = result.matchreport("test_failing", when="call")
-    scenario = test_report_context[report].scenario
+    scenario = test_report_context_registry[report].scenario
     expected = {
         "feature": {
             "description": "",
@@ -182,7 +182,7 @@ def _(cucumbers, left):
     assert scenario == expected
 
     report = result.matchreport("test_outlined[12-5-7]", when="call")
-    scenario = test_report_context[report].scenario
+    scenario = test_report_context_registry[report].scenario
     expected = {
         "feature": {
             "description": "",
@@ -228,7 +228,7 @@ def _(cucumbers, left):
     assert scenario == expected
 
     report = result.matchreport("test_outlined[5-4-1]", when="call")
-    scenario = test_report_context[report].scenario
+    scenario = test_report_context_registry[report].scenario
     expected = {
         "feature": {
             "description": "",
@@ -337,6 +337,6 @@ def test_complex(alien):
     report = result.matchreport("test_complex[10,20-alien0]", when="call")
     assert report.passed
 
-    report_context = test_report_context[report]
+    report_context = test_report_context_registry[report]
     assert execnet.gateway_base.dumps(report_context.name)
     assert execnet.gateway_base.dumps(report_context.scenario)