Merge pull request #720 from pytest-dev/linters

Add flake8 linters

Author: youtux

.pre-commit-config.yaml

@@ -23,9 +23,11 @@ repos:
     hooks:
     -   id: pyupgrade
         args: ["--py39-plus"]
-# TODO: Enable mypy checker when the checks succeed
-#-   repo: https://github.com/pre-commit/mirrors-mypy
-#    rev: v0.931
-#    hooks:
-#    -   id: mypy
-#        additional_dependencies: [types-setuptools]
+-   repo: https://github.com/pycqa/flake8
+    rev: "7.1.1"
+    hooks:
+    -   id: flake8
+        additional_dependencies: [
+          "flake8-pyproject",
+          "flake8-bugbear",
+        ]

docs/conf.py

@@ -20,8 +20,6 @@
 
 sys.path.insert(0, os.path.abspath(".."))
 
-import pytest_bdd
-
 # -- General configuration -----------------------------------------------------
 
 # If your documentation needs a minimal Sphinx version, state it here.
@@ -175,11 +173,11 @@
 
 latex_elements = {
     # The paper size ('letterpaper' or 'a4paper').
-    #'papersize': 'letterpaper',
+    # 'papersize': 'letterpaper',
     # The font size ('10pt', '11pt' or '12pt').
-    #'pointsize': '10pt',
+    # 'pointsize': '10pt',
     # Additional stuff for the LaTeX preamble.
-    #'preamble': '',
+    # 'preamble': '',
 }
 
 # Grouping the document tree into LaTeX files. List of tuples

pyproject.toml

@@ -59,6 +59,13 @@ build-backend = "poetry.core.masonry.api"
 line-length = 120
 target-version = ["py39", "py310", "py311", "py312"]
 
+[tool.flake8]
+# E1: indentation: already covered by `black`
+# E2: whitespace: already covered by `black`
+# E3: blank line: already covered by `black`
+# E501: line length: already covered by `black`
+extend-ignore = "E1,E2,E3,E501"
+
 [tool.isort]
 profile = "black"
 line_length = 120

src/pytest_bdd/parser.py

@@ -17,7 +17,7 @@
 from .gherkin_parser import Step as GherkinStep
 from .gherkin_parser import Tag as GherkinTag
 from .gherkin_parser import get_gherkin_document
-from .types import GIVEN, STEP_TYPES, THEN, WHEN
+from .types import STEP_TYPES
 
 STEP_PARAM_RE = re.compile(r"<(.+?)>")
 COMMENT_RE = re.compile(r"(^|(?<=\s))#")

src/pytest_bdd/scenario.py

@@ -51,7 +51,7 @@ def find_fixturedefs_for_step(step: Step, fixturemanager: FixtureManager, node:
     # happens to be that _arg2fixturedefs is changed during the iteration so we use a copy
     fixture_def_by_name = list(fixturemanager._arg2fixturedefs.items())
     for fixturename, fixturedefs in fixture_def_by_name:
-        for pos, fixturedef in enumerate(fixturedefs):
+        for _, fixturedef in enumerate(fixturedefs):
             step_func_context = getattr(fixturedef.func, "_pytest_bdd_step_context", None)
             if step_func_context is None:
                 continue

tests/datatable/test_datatable.py

@@ -1,5 +1,4 @@
 import textwrap
-from typing import List
 
 from src.pytest_bdd.utils import collect_dumped_objects
 

tests/feature/test_cucumber_json.py

@@ -8,8 +8,6 @@
 from typing import TYPE_CHECKING, Any
 
 if TYPE_CHECKING:
-    from typing import Optional
-
     from _pytest.pytester import Pytester, RunResult
 
 

tests/steps/test_common.py

@@ -4,7 +4,7 @@
 
 import pytest
 
-from pytest_bdd import given, parser, parsers, then, when
+from pytest_bdd import given, parsers, then, when
 from pytest_bdd.utils import collect_dumped_objects