Feedback response

Author: jsa34

src/pytest_bdd/generation.py

@@ -11,7 +11,7 @@
 
 from .compat import getfixturedefs
 from .feature import get_features
-from .parser import Feature, Rule, ScenarioTemplate, Step
+from .parser import Feature, ScenarioTemplate, Step
 from .scenario import inject_fixturedefs_for_step, make_python_docstring, make_python_name, make_string_literal
 from .steps import get_step_fixture_name
 from .types import STEP_TYPES
@@ -110,21 +110,7 @@ def print_missing_code(scenarios: list[ScenarioTemplate], steps: list[Step]) ->
                 red=True,
             )
         elif step.background is not None:
-            parent = step.background.parent
-
-            if isinstance(parent, Rule):
-                parent_type = "rule"
-                filename = parent.feature.filename
-            elif isinstance(parent, Feature):
-                parent_type = "feature"
-                filename = parent.filename
-            else:
-                raise NotImplementedError(f"Unhandled parent type: {type(parent)}")
-
-            message = (
-                f"Step {step} is not defined in the background of the {parent_type} "
-                f'"{parent.name}" in the file {filename}:{step.line_number}'
-            )
+            message = f"Background step {step} is not defined."
             tw.line(message, red=True)
 
     if step:

src/pytest_bdd/parser.py

@@ -169,13 +169,7 @@ def steps(self) -> list[Step]:
         Returns:
             List[Step]: A list of steps, including any background steps from the feature.
         """
-        steps = []
-        # Add all background steps
-        steps.extend(self.all_background_steps)
-        # Add the scenario's own steps
-        steps.extend(self._steps)
-
-        return steps
+        return self.all_background_steps + self._steps
 
     def render(self, context: Mapping[str, Any]) -> Scenario:
         """Render the scenario with the given context.
@@ -328,12 +322,10 @@ class Background:
     """Represents the background steps for a feature.
 
     Attributes:
-        parent (Feature | Rule): The feature or rule to which this background belongs.
         line_number (int): The line number where the background starts in the file.
         steps (List[Step]): The list of steps in the background.
     """
 
-    parent: Feature | Rule
     line_number: int
     steps: list[Step] = field(init=False, default_factory=list)
 
@@ -455,9 +447,8 @@ def parse_scenario(
 
         return scenario
 
-    def parse_background(self, background_data: GherkinBackground, parent: Feature | Rule) -> Background:
+    def parse_background(self, background_data: GherkinBackground) -> Background:
         background = Background(
-            parent=parent,
             line_number=background_data.location.line,
         )
         background.steps = self.parse_steps(background_data.steps)
@@ -492,7 +483,7 @@ def parse(self) -> Feature:
 
         for child in feature_data.children:
             if child.background:
-                feature.background = self.parse_background(child.background, feature)
+                feature.background = self.parse_background(child.background)
             elif child.rule:
                 self._parse_and_add_rule(child.rule, feature)
             elif child.scenario:
@@ -511,7 +502,7 @@ def _parse_and_add_rule(self, rule_data: GherkinRule, feature: Feature) -> None:
         )
 
         # Add background if present within the rule
-        background = self._extract_rule_background(rule_data, rule)
+        background = self._extract_rule_background(rule_data)
         if background:
             rule.add_background(background)
 
@@ -520,11 +511,11 @@ def _parse_and_add_rule(self, rule_data: GherkinRule, feature: Feature) -> None:
             scenario = self.parse_scenario(rule_scenario, feature, rule)
             feature.scenarios[scenario.name] = scenario
 
-    def _extract_rule_background(self, rule_data: GherkinRule, rule: Rule) -> Background | None:
+    def _extract_rule_background(self, rule_data: GherkinRule) -> Background | None:
         """Extract the first background from rule children if it exists."""
         for child in rule_data.children:
             if child.background:
-                return self.parse_background(child.background, rule)
+                return self.parse_background(child.background)
         return None
 
     @staticmethod

tests/generation/test_generate_missing.py

@@ -80,9 +80,7 @@ def test_missing_steps():
         ]
     )
 
-    result.stdout.fnmatch_lines(
-        ['Step Given "I have a foobar" is not defined in the background of the feature "Missing code generation" *']
-    )
+    result.stdout.fnmatch_lines(['Background step Given "I have a foobar" is not defined*'])
 
     result.stdout.fnmatch_lines(["Please place the code above to the test file(s):"])