Remove accidental duplication of code

Remove unnecessary safeguards (as the parser already does these!)
Add test to increase coverage

Author: jsa34

src/pytest_bdd/gherkin_parser.py

@@ -130,8 +130,6 @@ def from_dict(cls, data: dict[str, Any]) -> Self:
 
     def transpose(self) -> DataTable:
         # Transpose the cells, turning rows into columns
-        if not self.rows:
-            return self  # Return itself if there are no rows to transpose
 
         # Get the list of lists of cell values (i.e., extract all row cells)
         cells_matrix = [row.cells for row in self.rows]
@@ -146,10 +144,7 @@ def transpose(self) -> DataTable:
             # Create a new list for each transposed column
             transposed_column = []
             for row in cells_matrix:
-                if col_idx < len(row):  # Ensure we don't go out of bounds
-                    transposed_column.append(row[col_idx])
-                else:
-                    transposed_column.append(Cell(location=Location(0, 0), value=""))  # Empty cell
+                transposed_column.append(row[col_idx])
 
             # Create a new row from the transposed column
             transposed_row = Row(id=str(col_idx), location=self.location, cells=transposed_column)

src/pytest_bdd/scenario.py

@@ -152,7 +152,13 @@ def get_fixture_path(fixture_def: FixtureDef) -> list[str]:
 
 
 def get_step_function(request: FixtureRequest, step: Step) -> StepFunctionContext | None:
-    """Get the step function (context) for the given step, considering data_table."""
+    """Get the step function (context) for the given step.
+    We first figure out what's the step fixture name that we have to inject.
+    Then we let `patch_argumented_step_functions` find out what step definition fixtures can parse the current step,
+    and it will inject them for the step fixture name.
+    Finally, we let request.getfixturevalue(...) fetch the step definition fixture.
+    Data tables are considered if the step has them defined.
+    """
     __tracebackhide__ = True
     bdd_name = get_step_fixture_name(step=step)
 
@@ -221,19 +227,13 @@ def _execute_step_function(
 
     request.config.hook.pytest_bdd_after_step(**kw)
 
-    if context.target_fixture is not None:
-        inject_fixture(request, context.target_fixture, return_value)
-
-    request.config.hook.pytest_bdd_after_step(**kw)
-
 
 def _execute_scenario(feature: Feature, scenario: Scenario, request: FixtureRequest) -> None:
     """Execute the scenario.
 
     :param feature: Feature.
     :param scenario: Scenario.
     :param request: request.
-    :param encoding: Encoding.
     """
     __tracebackhide__ = True
     request.config.hook.pytest_bdd_before_scenario(request=request, feature=feature, scenario=scenario)

tests/datatable/test_datatable.py

@@ -27,7 +27,7 @@
 
 
 DATA_TABLE_STEPS = """\
-        from pytest_bdd import given, when, then, parsers
+        from pytest_bdd import given, when, then
         from pytest_bdd.utils import dump_obj
 
 
@@ -56,7 +56,7 @@ def _(data_table):
         from pytest_bdd import scenario
 
         @scenario("data_table.feature", "Creating a new user with roles and permissions")
-        def test_outline():
+        def test_data_table():
             pass
         """
 
@@ -165,7 +165,7 @@ def test_steps_with_missing_data_tables(pytester):
     pytester.makeconftest(
         textwrap.dedent(
             """\
-        from pytest_bdd import given, when, then, parsers
+        from pytest_bdd import given, when, then
         from pytest_bdd.utils import dump_obj
 
 
@@ -196,11 +196,56 @@ def _(data_table):
         from pytest_bdd import scenario
 
         @scenario("missing_data_table.feature", "Data table is missing for a step")
-        def test_outline():
+        def test_data_table():
             pass
         """
         )
     )
     result = pytester.runpytest("-s")
     result.assert_outcomes(failed=1)
     result.stdout.fnmatch_lines(["*fixture 'data_table' not found*"])
+
+
+def test_steps_with_data_tables_too_short_for_to_dict(pytester):
+    pytester.makefile(
+        ".feature",
+        too_short_data_table=textwrap.dedent(
+            """\
+            Feature: Short data table
+
+              Scenario: Data table too short for transforming to dict
+                Given this step has a data table:
+                  | name  | email             | age |
+
+            """
+        ),
+    )
+    pytester.makeconftest(
+        textwrap.dedent(
+            """\
+        from pytest_bdd import given, when, then
+
+
+        @given("this step has a data table:")
+        def _(data_table):
+            data_table.to_dict()
+
+    """
+        )
+    )
+
+    pytester.makepyfile(
+        textwrap.dedent(
+            """\
+        from pytest_bdd.utils import dump_obj
+        from pytest_bdd import scenario
+
+        @scenario("too_short_data_table.feature", "Data table too short for transforming to dict")
+        def test_data_table():
+            pass
+        """
+        )
+    )
+    result = pytester.runpytest("-s")
+    result.assert_outcomes(failed=1)
+    result.stdout.fnmatch_lines(["*ValueError: DataTable needs at least two rows: one for headers and one for values*"])