Skip to content

Commit 8f8aaa3

Browse files
authored
Merge pull request #92 from nicoddemus/release-2.3.0
Prepare release 2.3.0
2 parents bfe587c + 445321d commit 8f8aaa3

File tree

7 files changed

+39
-17
lines changed

7 files changed

+39
-17
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# 2.2.2 (UNRELEASED)
1+
# 2.3.0 (2023-01-30)
22

33
- New `cpp_harness_collect` configuration option allows users to add prefix arguments to run C++ test executables, allowing to use additional tools like `wine` of `qemu` for a test runners in cross-platform development.
44

src/pytest_cpp/boost.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,17 @@ def read_file(name: str) -> str:
6969
except ValueError:
7070
log_xml = os.path.join(temp_dir, "log.xml")
7171
report_xml = os.path.join(temp_dir, "report.xml")
72-
args = make_cmdline(harness, executable, ["--output_format=XML", f"--log_sink={log_xml}", f"--report_sink={report_xml}"])
72+
args = list(
73+
make_cmdline(
74+
harness,
75+
executable,
76+
[
77+
"--output_format=XML",
78+
f"--log_sink={log_xml}",
79+
f"--report_sink={report_xml}",
80+
],
81+
)
82+
)
7383
args.extend(test_args)
7484

7585
p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)

src/pytest_cpp/catch2.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,13 @@ def run_test(
8181
xml_filename = os.path.join(os.path.relpath(temp_dir), "cpp-report.xml")
8282
except ValueError:
8383
xml_filename = os.path.join(temp_dir, "cpp-report.xml")
84-
args = make_cmdline(harness, executable, [test_id, "--success", "--reporter=xml", f"--out {xml_filename}"])
84+
args = list(
85+
make_cmdline(
86+
harness,
87+
executable,
88+
[test_id, "--success", "--reporter=xml", f"--out {xml_filename}"],
89+
)
90+
)
8591
args.extend(test_args)
8692

8793
try:

src/pytest_cpp/google.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,13 @@ def run_test(
8989
xml_filename = os.path.join(os.path.relpath(temp_dir), "cpp-report.xml")
9090
except ValueError:
9191
xml_filename = os.path.join(temp_dir, "cpp-report.xml")
92-
args = make_cmdline(harness, executable, [f"--gtest_filter={test_id}", f"--gtest_output=xml:{xml_filename}"])
92+
args = list(
93+
make_cmdline(
94+
harness,
95+
executable,
96+
[f"--gtest_filter={test_id}", f"--gtest_output=xml:{xml_filename}"],
97+
)
98+
)
9399
args.extend(test_args)
94100

95101
try:

src/pytest_cpp/helpers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
21
from typing import Sequence
32

43

5-
def make_cmdline(harness: Sequence[str], executable: str, arg: Sequence[str] = ()) ->Sequence[str]:
4+
def make_cmdline(
5+
harness: Sequence[str], executable: str, arg: Sequence[str] = ()
6+
) -> Sequence[str]:
67
return [*harness, executable, *arg]

src/pytest_cpp/plugin.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,7 @@ def pytest_collect_file(
6969

7070
harness_collect = parent.config.getini("cpp_harness_collect")
7171
for facade_class in FACADES:
72-
if facade_class.is_test_suite(
73-
str(file_path),
74-
harness_collect=harness_collect
75-
):
72+
if facade_class.is_test_suite(str(file_path), harness_collect=harness_collect):
7673
return CppFile.from_parent(
7774
path=file_path,
7875
parent=parent,
@@ -154,11 +151,11 @@ def from_parent( # type:ignore[override]
154151
)
155152

156153
def collect(self) -> Iterator[CppItem]:
157-
harness_collect=self.config.getini("cpp_harness_collect")
154+
harness_collect = self.config.getini("cpp_harness_collect")
158155
for test_id in self.facade.list_tests(
159-
str(self.fspath),
160-
harness_collect=harness_collect,
161-
):
156+
str(self.fspath),
157+
harness_collect=harness_collect,
158+
):
162159
yield CppItem.from_parent(
163160
parent=self,
164161
name=test_id,

tests/test_pytest_cpp.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,17 +93,19 @@ def test_success(facade, name, test_id, exes):
9393

9494

9595
def test_cmdline_builder_happy_flow():
96-
arg_string = make_cmdline( ["wine"], "gtest", ["--help"] )
96+
arg_string = make_cmdline(["wine"], "gtest", ["--help"])
9797
assert arg_string == ["wine", "gtest", "--help"]
9898

9999

100100
def test_cmdline_builder_with_empty_harness():
101-
arg_string = make_cmdline(list(), "boost_test", ["--output_format=XML", "--log_sink=dummy.log"])
101+
arg_string = make_cmdline(
102+
list(), "boost_test", ["--output_format=XML", "--log_sink=dummy.log"]
103+
)
102104
assert arg_string == ["boost_test", "--output_format=XML", "--log_sink=dummy.log"]
103105

104106

105107
def test_cmdline_builder_with_empty_args():
106-
arg_string = make_cmdline( ["wine"], "gtest")
108+
arg_string = make_cmdline(["wine"], "gtest")
107109
assert arg_string == ["wine", "gtest"]
108110

109111

0 commit comments

Comments
 (0)