consider catch2's FAIL()

sshane · sshane · commit c334cd4f4cf5 · 2024-09-17T15:54:26.000-07:00
diff --git a/src/pytest_cpp/catch2.py b/src/pytest_cpp/catch2.py
@@ -199,11 +199,12 @@ def _parse_xml(
                                 )
                             )
                     test_exception = test_case.findall(".//Exception")
-                    for exception in test_exception:
+                    test_failure = test_case.findall(".//Failure")
+                    for exception in (test_exception + test_failure):
                         file_name = exception.attrib["filename"]
                         line_num = int(exception.attrib["line"])
 
-                        fail_msg = f"Error: {exception.text}"
+                        fail_msg = f"Error: {exception.text.strip()}"
                         failures.append(
                             (
                                 file_name,

Original file line number	Diff line number	Diff line change
`@@ -199,11 +199,12 @@ def _parse_xml(`
`199`	`199`	`)`
`200`	`200`	`)`
`201`	`201`	`test_exception = test_case.findall(".//Exception")`
`202`		`- for exception in test_exception:`
	`202`	`+ test_failure = test_case.findall(".//Failure")`
	`203`	`+ for exception in (test_exception + test_failure):`
`203`	`204`	`file_name = exception.attrib["filename"]`
`204`	`205`	`line_num = int(exception.attrib["line"])`
`205`	`206`
`206`		`- fail_msg = f"Error: {exception.text}"`
	`207`	`+ fail_msg = f"Error: {exception.text.strip()}"`
`207`	`208`	`failures.append(`
`208`	`209`	`(`
`209`	`210`	`file_name,`