Skip to content

Commit 42b7db2

Browse files
authored
Fix assert function signatures that expect HTTP response (#1036)
Co-authored-by: Matthias Schoettle <[email protected]>
1 parent 1f3708a commit 42b7db2

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

pytest_django/asserts.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ def assertion_func(*args, **kwargs):
4040

4141

4242
if TYPE_CHECKING:
43-
from django.http import HttpResponse
43+
from django.http.response import HttpResponseBase
4444

4545
def assertRedirects(
46-
response: HttpResponse,
46+
response: HttpResponseBase,
4747
expected_url: str,
4848
status_code: int = ...,
4949
target_status_code: int = ...,
@@ -60,7 +60,7 @@ def assertURLEqual(
6060
...
6161

6262
def assertContains(
63-
response: HttpResponse,
63+
response: HttpResponseBase,
6464
text: object,
6565
count: Optional[int] = ...,
6666
status_code: int = ...,
@@ -70,7 +70,7 @@ def assertContains(
7070
...
7171

7272
def assertNotContains(
73-
response: HttpResponse,
73+
response: HttpResponseBase,
7474
text: object,
7575
status_code: int = ...,
7676
msg_prefix: str = ...,
@@ -79,7 +79,7 @@ def assertNotContains(
7979
...
8080

8181
def assertFormError(
82-
response: HttpResponse,
82+
response: HttpResponseBase,
8383
form: str,
8484
field: Optional[str],
8585
errors: Union[str, Sequence[str]],
@@ -88,7 +88,7 @@ def assertFormError(
8888
...
8989

9090
def assertFormsetError(
91-
response: HttpResponse,
91+
response: HttpResponseBase,
9292
formset: str,
9393
form_index: Optional[int],
9494
field: Optional[str],
@@ -98,15 +98,15 @@ def assertFormsetError(
9898
...
9999

100100
def assertTemplateUsed(
101-
response: Optional[HttpResponse] = ...,
101+
response: Optional[Union[HttpResponseBase, str]] = ...,
102102
template_name: Optional[str] = ...,
103103
msg_prefix: str = ...,
104104
count: Optional[int] = ...,
105105
):
106106
...
107107

108108
def assertTemplateNotUsed(
109-
response: Optional[HttpResponse] = ...,
109+
response: Optional[Union[HttpResponseBase, str]] = ...,
110110
template_name: Optional[str] = ...,
111111
msg_prefix: str = ...,
112112
):

0 commit comments

Comments
 (0)