Remove testing on MyISAM

MyISAM testing was added back in 2012 (#78) because it would have detected one bug in relation to transactional ordering.

MyISAM was not recommended back then and even less so now. It’s non-transactional nature has many implications and [Django’s database documentation](https://docs.djangoproject.com/en/stable/ref/databases/) caveats against using it.

I think we can remove the testing now and reduce the maintenance burden. As far as I can tell, it was only added retroactively to guard against that one bug, 13 years ago.

Author: adamchainz

.github/workflows/main.yml

@@ -95,15 +95,15 @@ jobs:
           python: '3.10'
           allow_failure: false
 
-        - name: py311-dj51-mysql_innodb-coverage
+        - name: py311-dj51-mysql-coverage
           python: '3.11'
           allow_failure: false
 
-        - name: py310-dj42-mysql_innodb-coverage
+        - name: py310-dj42-mysql-coverage
           python: '3.10'
           allow_failure: false
 
-        - name: py39-dj42-mysql_innodb-xdist-coverage
+        - name: py39-dj42-mysql-xdist-coverage
           python: '3.9'
           allow_failure: false
 
@@ -123,10 +123,6 @@ jobs:
           python: '3.8'
           allow_failure: false
 
-        - name: py311-dj42-mysql_myisam-coverage
-          python: '3.11'
-          allow_failure: false
-
         # Explicitly test min pytest.
         - name: py38-dj42-sqlite-pytestmin-coverage
           python: '3.8'

docs/contributing.rst

@@ -140,7 +140,7 @@ writing), running them all will take a long time. All valid configurations can
 be found in `tox.ini`. To test against a few of them, invoke tox with the `-e`
 flag::
 
-    $ tox -e py38-dj32-postgres,py310-dj41-mysql_innodb
+    $ tox -e py38-dj32-postgres,py310-dj41-mysql
 
 This will run the tests on Python 3.8/Django 3.2/PostgeSQL and Python
 3.10/Django 4.1/MySQL.

pytest_django_test/settings_mysql_innodb.py renamed to pytest_django_test/settings_mysql.py

@@ -11,7 +11,6 @@
         "PASSWORD": environ.get("TEST_DB_PASSWORD", ""),
         "HOST": environ.get("TEST_DB_HOST", "localhost"),
         "OPTIONS": {
-            "init_command": "SET default_storage_engine=InnoDB",
             "charset": "utf8mb4",
         },
         "TEST": {
@@ -26,7 +25,6 @@
         "PASSWORD": environ.get("TEST_DB_PASSWORD", ""),
         "HOST": environ.get("TEST_DB_HOST", "localhost"),
         "OPTIONS": {
-            "init_command": "SET default_storage_engine=InnoDB",
             "charset": "utf8mb4",
         },
         "TEST": {
@@ -42,7 +40,6 @@
         "PASSWORD": environ.get("TEST_DB_PASSWORD", ""),
         "HOST": environ.get("TEST_DB_HOST", "localhost"),
         "OPTIONS": {
-            "init_command": "SET default_storage_engine=InnoDB",
             "charset": "utf8mb4",
         },
         "TEST": {

pytest_django_test/settings_mysql_myisam.py

@@ -16,8 +16,7 @@ deps =
     dj50: Django>=5.0,<5.1
     dj42: Django>=4.2,<4.3
 
-    mysql_myisam: mysqlclient==2.1.0
-    mysql_innodb: mysqlclient==2.1.0
+    mysql: mysqlclient==2.1.0
 
     postgres: psycopg[binary]
     coverage: coverage[toml]
@@ -27,8 +26,7 @@ deps =
     xdist: pytest-xdist>=1.15
 
 setenv =
-    mysql_innodb: DJANGO_SETTINGS_MODULE=pytest_django_test.settings_mysql_innodb
-    mysql_myisam: DJANGO_SETTINGS_MODULE=pytest_django_test.settings_mysql_myisam
+    mysql: DJANGO_SETTINGS_MODULE=pytest_django_test.settings_mysql
     postgres:     DJANGO_SETTINGS_MODULE=pytest_django_test.settings_postgres
     sqlite:       DJANGO_SETTINGS_MODULE=pytest_django_test.settings_sqlite
     sqlite_file:  DJANGO_SETTINGS_MODULE=pytest_django_test.settings_sqlite_file