Skip to content

Commit ef83478

Browse files
committed
Remove is_valid_path and force_text compat shims.
1 parent 808370d commit ef83478

File tree

4 files changed

+7
-35
lines changed

4 files changed

+7
-35
lines changed

pytest_django_test/compat.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
try:
2-
from django.utils.encoding import force_text # noqa
3-
except ImportError:
4-
from django.utils.encoding import force_unicode as force_text # noqa
5-
6-
71
try:
82
from urllib2 import urlopen, HTTPError # noqa
93
except ImportError:

pytest_django_test/db_helpers.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55
import pytest
66

77
from django.conf import settings
8-
9-
from .compat import force_text
8+
from django.utils.encoding import force_text
109

1110

1211
# Construct names for the "inner" database used in runpytest tests

tests/test_fixtures.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@
1212
from django.conf import settings as real_settings
1313
from django.test.client import Client, RequestFactory
1414
from django.test.testcases import connections_support_transactions
15+
from django.utils.encoding import force_text
1516

1617
from pytest_django.lazy_django import get_django_version
1718
from pytest_django_test.app.models import Item
18-
from pytest_django_test.compat import force_text, HTTPError, urlopen
19+
from pytest_django_test.compat import HTTPError, urlopen
1920

2021

2122
def test_client(client):
@@ -156,10 +157,7 @@ def test_serve_static_with_staticfiles_app(self, django_testdir, settings):
156157
"""
157158
django_testdir.create_test_module("""
158159
import pytest
159-
try:
160-
from django.utils.encoding import force_text
161-
except ImportError:
162-
from django.utils.encoding import force_unicode as force_text
160+
from django.utils.encoding import force_text
163161
164162
try:
165163
from urllib2 import urlopen, HTTPError
@@ -235,7 +233,7 @@ def admin_required_view(request):
235233
Template('Access denied').render(Context()))
236234
""", 'views.py')
237235
django_testdir.makepyfile("""
238-
from pytest_django_test.compat import force_text
236+
from django.utils.encoding import force_text
239237
from tpkg.app.models import MyCustomUser
240238
241239
def test_custom_user_model(admin_client):

tests/test_urls.py

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,7 @@
11
import pytest
22
from django.conf import settings
3-
4-
from pytest_django_test.compat import force_text
5-
6-
7-
try:
8-
from django.core.urlresolvers import is_valid_path
9-
except ImportError:
10-
from django.core.urlresolvers import resolve, Resolver404
11-
12-
def is_valid_path(path, urlconf=None):
13-
"""Return True if path resolves against default URL resolver
14-
15-
This is a convenience method to make working with "is this a
16-
match?" cases easier, avoiding unnecessarily indented
17-
try...except blocks.
18-
"""
19-
try:
20-
resolve(path, urlconf)
21-
return True
22-
except Resolver404:
23-
return False
3+
from django.core.urlresolvers import is_valid_path
4+
from django.utils.encoding import force_text
245

256

267
@pytest.mark.urls('pytest_django_test.urls_overridden')

0 commit comments

Comments
 (0)