Skip to content

Commit fd8ff0b

Browse files
authored
_assert_num_queries: make code clearer (#667)
Closes #661.
1 parent 9804e61 commit fd8ff0b

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

pytest_django/fixtures.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ def _live_server_helper(request):
407407

408408

409409
@contextmanager
410-
def _assert_num_queries(config, num, exact=True, connection=None):
410+
def _assert_num_queries(config, num_expected, exact=True, connection=None):
411411
from django.test.utils import CaptureQueriesContext
412412

413413
if connection is None:
@@ -416,14 +416,17 @@ def _assert_num_queries(config, num, exact=True, connection=None):
416416
verbose = config.getoption("verbose") > 0
417417
with CaptureQueriesContext(connection) as context:
418418
yield context
419-
num_queries = len(context)
420-
failed = num != num_queries if exact else num < num_queries
419+
num_performed = len(context)
420+
if exact:
421+
failed = num_expected != num_performed
422+
else:
423+
failed = num_performed > num_expected
421424
if failed:
422425
msg = "Expected to perform {} queries {}{}".format(
423-
num,
426+
num_expected,
424427
"" if exact else "or less ",
425428
"but {} done".format(
426-
num_queries == 1 and "1 was" or "%d were" % (num_queries,)
429+
num_performed == 1 and "1 was" or "%d were" % (num_performed,)
427430
),
428431
)
429432
if verbose:

0 commit comments

Comments
 (0)