-
Notifications
You must be signed in to change notification settings - Fork 252
Open
Labels
InfrastructureChanges related to project infrastructure ( CI/CD, deploy mechanism, etc. )Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )code qualityThis PR has to do with improving code readability/quality ( refactoring, etc. )This PR has to do with improving code readability/quality ( refactoring, etc. )
Description
This project's python code should be typed, and type checking should be part of the CI pipeline. I propose using mypy, we can look at pytest for an example of how to integrate it.
I'm going to try and add in typing. I'll perform changes on a per module level so the reviews are smaller and close this issue when the typing effort is complete. I'll update this issue as I progress
We'd need to do the following subtasks:
Add mypy to our project:done in Add mypy to CI pipeline and begin typing modules #435Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/__init__.py:done in Add mypy to CI pipeline and begin typing modules #435Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/extras.py:done in Add mypy to CI pipeline and begin typing modules #435- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/hooks.py
- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/html_report.py
Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/outcome.py:done in Add mypy to CI pipeline and begin typing modules #435- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/plugin.py
- Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/result.py
Type https://github.com/pytest-dev/pytest-html/blob/master/src/pytest_html/util.py: done in Add mypy to CI pipeline and begin typing modules #435- Type https://github.com/pytest-dev/pytest-html/blob/master/testing/test_pytest_html.py
jkowalleck
Metadata
Metadata
Assignees
Labels
InfrastructureChanges related to project infrastructure ( CI/CD, deploy mechanism, etc. )Changes related to project infrastructure ( CI/CD, deploy mechanism, etc. )code qualityThis PR has to do with improving code readability/quality ( refactoring, etc. )This PR has to do with improving code readability/quality ( refactoring, etc. )