Skip to content

Commit 13f27a0

Browse files
authored
Merge pull request #27 from ftobia/feature/minor-cleanup
Minor cleanup
2 parents 4699ba8 + 6561212 commit 13f27a0

File tree

5 files changed

+20
-12
lines changed

5 files changed

+20
-12
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,6 @@ nosetests.xml
4040
.mr.developer.cfg
4141
.project
4242
.pydevproject
43+
44+
# Misc
45+
.cache

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
language: python
2-
python: 2.7
2+
python: "3.5"
33
env:
4+
- TOX_ENV=py35
5+
- TOX_ENV=py34
46
- TOX_ENV=py33
57
- TOX_ENV=py27
68
- TOX_ENV=py26

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
Frank Tobia <[email protected]>
22
Sergei Chipiga <[email protected]>
3+
Ben Greene <[email protected]>

pytest_ordering/__init__.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# -*- coding: utf-8 -*-
22
from ._version import __version__
33

4+
import operator
5+
46
import pytest
57

68
orders_map = {
@@ -55,16 +57,16 @@ def pytest_collection_modifyitems(session, config, items):
5557

5658
grouped_items.setdefault(order, []).append(item)
5759

58-
if grouped_items:
59-
sorted_items = []
60-
61-
unordered_items = [grouped_items.pop(None, [])]
60+
sorted_items = []
61+
unordered_items = [grouped_items.pop(None, [])]
6262

63-
start_list = sorted((i for i in grouped_items.items() if i[0] >= 0), key=lambda x: x[0])
64-
end_list = sorted((i for i in grouped_items.items() if i[0] < 0), key=lambda x: x[0])
63+
start_list = sorted((i for i in grouped_items.items() if i[0] >= 0),
64+
key=operator.itemgetter(0))
65+
end_list = sorted((i for i in grouped_items.items() if i[0] < 0),
66+
key=operator.itemgetter(0))
6567

66-
sorted_items.extend([i[1] for i in start_list])
67-
sorted_items.extend(unordered_items)
68-
sorted_items.extend([i[1] for i in end_list])
68+
sorted_items.extend([i[1] for i in start_list])
69+
sorted_items.extend(unordered_items)
70+
sorted_items.extend([i[1] for i in end_list])
6971

70-
items[:] = [item for sublist in sorted_items for item in sublist]
72+
items[:] = [item for sublist in sorted_items for item in sublist]

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# content of: tox.ini, put in same dir as setup.py
22
[tox]
3-
envlist = py26,py27,py32,py33,pypy
3+
envlist = py26,py27,py33,py34,py35,pypy
44
[testenv]
55
deps=pytest
66
pytest-cov

0 commit comments

Comments
 (0)