Skip to content

Commit 380f04f

Browse files
committed
Get test coverage to 100% (remove pointless zero-test handling).
Use operator.itemgetter. PEP-8 line length.
1 parent b381efe commit 380f04f

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

pytest_ordering/__init__.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# -*- coding: utf-8 -*-
22
from ._version import __version__
33

4+
import operator
5+
46
import pytest
57

68
orders_map = {
@@ -55,16 +57,16 @@ def pytest_collection_modifyitems(session, config, items):
5557

5658
grouped_items.setdefault(order, []).append(item)
5759

58-
if grouped_items:
59-
sorted_items = []
60-
61-
unordered_items = [grouped_items.pop(None, [])]
60+
sorted_items = []
61+
unordered_items = [grouped_items.pop(None, [])]
6262

63-
start_list = sorted((i for i in grouped_items.items() if i[0] >= 0), key=lambda x: x[0])
64-
end_list = sorted((i for i in grouped_items.items() if i[0] < 0), key=lambda x: x[0])
63+
start_list = sorted((i for i in grouped_items.items() if i[0] >= 0),
64+
key=operator.itemgetter(0))
65+
end_list = sorted((i for i in grouped_items.items() if i[0] < 0),
66+
key=operator.itemgetter(0))
6567

66-
sorted_items.extend([i[1] for i in start_list])
67-
sorted_items.extend(unordered_items)
68-
sorted_items.extend([i[1] for i in end_list])
68+
sorted_items.extend([i[1] for i in start_list])
69+
sorted_items.extend(unordered_items)
70+
sorted_items.extend([i[1] for i in end_list])
6971

70-
items[:] = [item for sublist in sorted_items for item in sublist]
72+
items[:] = [item for sublist in sorted_items for item in sublist]

0 commit comments

Comments
 (0)