The relative warning now specifies which test can't be sorted (#30)

* The relative warning now specifies which test can't be sorted
* Adjust tests to match the warning change

Author: DevilXD

pytest_order/sorter.py

@@ -177,8 +177,8 @@ def handle_before_or_after_mark(
             is_after: bool) -> bool:
         def is_class_mark() -> bool:
             return (
-                    item.item.cls and
-                    item.item.parent.get_closest_marker("order") == mark
+                item.item.cls and
+                item.item.parent.get_closest_marker("order") == mark
             )
 
         def is_mark_for_class() -> bool:
@@ -219,7 +219,7 @@ def handle_relative_marks(self, item: Item, mark: Mark) -> bool:
                     item, mark, before_mark, is_after=False):
                 has_relative_marks = True
             else:
-                self.warn_about_unknown_test(before_mark)
+                self.warn_about_unknown_test(item, before_mark)
         after_marks = mark.kwargs.get("after", ())
         if after_marks and not isinstance(after_marks, (list, tuple)):
             after_marks = (after_marks,)
@@ -228,13 +228,15 @@ def handle_relative_marks(self, item: Item, mark: Mark) -> bool:
                     item, mark, after_mark, is_after=True):
                 has_relative_marks = True
             else:
-                self.warn_about_unknown_test(after_mark)
+                self.warn_about_unknown_test(item, after_mark)
         return has_relative_marks
 
     @staticmethod
-    def warn_about_unknown_test(rel_mark: str) -> None:
-        sys.stdout.write("\nWARNING: cannot execute test relative to others:"
-                         " {} - ignoring the marker.".format(rel_mark))
+    def warn_about_unknown_test(item: Item, rel_mark: str) -> None:
+        sys.stdout.write(
+            "\nWARNING: cannot execute '{}' relative to others: "
+            "'{}' - ignoring the marker.".format(item.item.name, rel_mark)
+        )
 
     def collect_markers(self) -> None:
         aliases = {}

tests/test_class_marks.py

@@ -59,7 +59,7 @@ def test_2(self): pass
         "Test1::test_1", "Test1::test_2", "Test2::test_1", "Test2::test_2"
     ]
     out, err = capsys.readouterr()
-    assert ("WARNING: cannot execute test relative to others: Test3 "
+    assert ("WARNING: cannot execute 'test_2' relative to others: 'Test3' "
             "- ignoring the marker" in out)
 
 

tests/test_order_group_scope_relative.py

@@ -60,7 +60,7 @@ def test_session_scope(fixture_path):
     result = fixture_path.runpytest("-v")
     result.assert_outcomes(passed=10, failed=0)
     result.stdout.fnmatch_lines([
-        "*invalid - ignoring the marker.*",
+        "*'invalid' - ignoring the marker.*",
         "test_rel1.py::Test1::test_two PASSED",
         "test_rel1.py::Test2::test_one PASSED",
         "test_rel3.py::test_two PASSED",

tests/test_relative_ordering.py

@@ -365,8 +365,8 @@ def test_2():
     """
     assert item_names_for(test_content) == ["test_1", "test_2"]
     out, err = capsys.readouterr()
-    warning = ("cannot execute test relative to others: "
-               "some_module.py::test_2 - ignoring the marker")
+    warning = ("cannot execute 'test_1' relative to others: "
+               "'some_module.py::test_2' - ignoring the marker")
     assert warning in out
 
 
@@ -386,8 +386,8 @@ def test_3():
     """
     assert item_names_for(test_content) == ["test_1", "test_2", "test_3"]
     out, err = capsys.readouterr()
-    warning = ("cannot execute test relative to others: "
-               "test_4 - ignoring the marker")
+    warning = ("cannot execute 'test_2' relative to others: "
+               "'test_4' - ignoring the marker")
     assert warning in out
 
 
@@ -410,8 +410,8 @@ def test_3(self):
         "Test::test_1", "Test::test_2", "Test::test_3"
     ]
     out, err = capsys.readouterr()
-    warning = ("cannot execute test relative to others: "
-               "test_4 - ignoring the marker")
+    warning = ("cannot execute 'test_2' relative to others: "
+               "'test_4' - ignoring the marker")
     assert warning in out