Add flake8-comprehensions

./testinfra/backend/salt.py:55:12: C407 Unnecessary list comprehension - 'any' can take a generator.
./testinfra/utils/ansible_runner.py:226:29: C414 Unnecessary list call within sorted().
./testinfra/modules/addr.py:97:21: C401 Unnecessary generator - rewrite as a set comprehension.

Author: philpep

testinfra/backend/salt.py

@@ -52,7 +52,7 @@ def run_salt(self, func, args=None):
     def get_hosts(cls, host, **kwargs):
         if host is None:
             host = "*"
-        if any([c in host for c in "@*[?"]):
+        if any(c in host for c in "@*[?"):
             client = salt.client.LocalClient()
             if "@" in host:
                 hosts = client.cmd(

testinfra/modules/addr.py

@@ -137,4 +137,4 @@ def _resolve(self, method):
         result = self.run_expect([0, 1, 2], "{}getent {} {}".format(
             self._prefix, method, self.name))
         lines = result.stdout.splitlines()
-        return list(set(line.split()[0] for line in lines))
+        return list({line.split()[0] for line in lines})

testinfra/utils/ansible_runner.py

@@ -223,7 +223,7 @@ def get_variables(self, host):
         for group in sorted(inventory):
             if group == "_meta":
                 continue
-            groups[group] = sorted(list(itergroup(inventory, group)))
+            groups[group] = sorted(itergroup(inventory, group))
             if group != "all" and host in inventory[group].get('hosts', []):
                 group_names.append(group)
         hostvars.setdefault('group_names', group_names)

tox.ini

@@ -20,6 +20,7 @@ deps=
   flake8
   hacking
   flake8-bugbear
+  flake8-comprehensions
 commands=flake8 {posargs}
 
 [testenv:docs]