Eventually decode ansible output when it's not ascii

ansible seems to write a json file using encoding of the remote system,
which might not be UTF-8

In order to decode such files properly, first try with ascii and
fallback to testinfra encoding detection if needed.

Author: philpep

testinfra/backend/ansible.py

@@ -65,8 +65,11 @@ def run(self, command, *args, **kwargs):
         )
 
     def run_ansible(self, module_name, module_args=None, **kwargs):
+        def get_encoding():
+            return self.encoding
+
         result = self.ansible_runner.run_module(
-            self.host, module_name, module_args, **kwargs
+            self.host, module_name, module_args, get_encoding=get_encoding, **kwargs
         )
         logger.info(
             "RUN Ansible(%s, %s, %s): %s",

testinfra/utils/ansible_runner.py

@@ -277,7 +277,7 @@ def options_to_cli(self, options):
                 raise TypeError("Unsupported argument type '{}'.".format(opt_type))
         return " ".join(cli), cli_args
 
-    def run_module(self, host, module_name, module_args, **options):
+    def run_module(self, host, module_name, module_args, get_encoding=None, **options):
         cmd, args = "ansible --tree %s", []
         if self.inventory_file:
             cmd += " -i %s"
@@ -307,8 +307,15 @@ def run_module(self, host, module_name, module_args, **options):
                 raise RuntimeError(
                     "Error while running {}: {}".format(" ".join(cmd), out)
                 )
-            with open(os.path.join(d, files[0]), "r") as f:
-                return json.load(f)
+            fpath = os.path.join(d, files[0])
+            try:
+                with open(fpath, "r", encoding="ascii") as f:
+                    return json.load(f)
+            except UnicodeDecodeError:
+                if get_encoding is None:
+                    raise
+                with open(fpath, "r", encoding=get_encoding()) as f:
+                    return json.load(f)
 
     @classmethod
     def get_runner(cls, inventory):