Merge pull request #140 from altendky/disable_signal_handlers

Author: altendky

pytest_twisted.py

@@ -1,6 +1,7 @@
 import functools
 import inspect
 import itertools
+import signal
 import sys
 import warnings
 
@@ -199,6 +200,11 @@ def init_twisted_greenlet():
         return
 
     if not _instances.reactor.running:
+        if signal.getsignal(signal.SIGINT) == signal.default_int_handler:
+            signal.signal(
+                signal.SIGINT,
+                functools.partial(signal.default_int_handler),
+            )
         _instances.gr_twisted = greenlet.greenlet(_instances.reactor.run)
         # give me better tracebacks:
         failure.Failure.cleanFailure = lambda self: None

testing/test_basic.py

@@ -1,4 +1,5 @@
 import os
+import re
 import sys
 import textwrap
 
@@ -13,6 +14,11 @@
 
 timeout = 15
 
+pytest_version = tuple(
+    int(segment)
+    for segment in pytest.__version__.split(".")[:3]
+)
+
 
 # https://github.com/pytest-dev/pytest/issues/6505
 def force_plural(name):
@@ -1179,3 +1185,73 @@ def test_succeed():
     testdir.makepyfile(test_file)
     rr = testdir.run(*cmd_opts, timeout=timeout)
     rr.stdout.fnmatch_lines(lines2=[test_string])
+
+
+def test_sigint_for_regular_tests(testdir, cmd_opts):
+    test_file = """
+    import os
+    import signal
+    import time
+
+    import twisted.internet
+    import twisted.internet.task
+
+    def test_self_cancel():
+        os.kill(os.getpid(), signal.SIGINT)
+        time.sleep(10)
+
+    def test_should_not_run():
+        assert False
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    if sys.platform != "win32":
+        # on Windows pytest isn't even reporting the status, just stopping...
+        assert_outcomes(rr, {})
+        rr.stdout.re_match_lines(lines2=[r".* no tests ran in .*"])
+
+    pattern = r".*test_should_not_run.*"
+
+    if pytest_version >= (5, 3, 0):
+        rr.stdout.no_re_match_line(pat=pattern)
+    else:
+        assert re.match(pattern, rr.stdout.str()) is None
+
+
+def test_sigint_for_inline_callbacks_tests(testdir, cmd_opts):
+    test_file = """
+    import os
+    import signal
+
+    import twisted.internet
+    import twisted.internet.task
+
+    import pytest_twisted
+
+    @pytest_twisted.inlineCallbacks
+    def test_self_cancel():
+        os.kill(os.getpid(), signal.SIGINT)
+        yield twisted.internet.task.deferLater(
+           twisted.internet.reactor,
+           9999,
+           lambda: None,
+        )
+
+    @pytest_twisted.inlineCallbacks
+    def test_should_not_run():
+        assert False
+        yield
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    if sys.platform != "win32":
+        # on Windows pytest isn't even reporting the status, just stopping...
+        assert_outcomes(rr, {})
+        rr.stdout.re_match_lines(lines2=[r".* no tests ran in .*"])
+
+    pattern = r".*test_should_not_run.*"
+
+    if pytest_version >= (5, 3, 0):
+        rr.stdout.no_re_match_line(pat=pattern)
+    else:
+        assert re.match(pattern, rr.stdout.str()) is None