Skip to content

Commit 7de9416

Browse files
committed
Add complaining TODO: about pytest_twisted.inlineCallbacks
1 parent c93ea0a commit 7de9416

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pytest_twisted.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,11 @@ def block_from_thread(d):
109109

110110
@decorator.decorator
111111
def inlineCallbacks(fun, *args, **kw):
112+
# TODO: it presumably doesn't matter but i really dislike how this
113+
# creates a new inlineCallbacks for each call. but, that's
114+
# a pretty irrelevant concern given that 1) it is just a function
115+
# call overhead and 2) lots of tests are only called once anyways.
116+
# but, this gets the feeling out of my head...
112117
return defer.inlineCallbacks(fun)(*args, **kw)
113118

114119

0 commit comments

Comments
 (0)