Merge pull request #63 from tyerq/feature/asyncio-reactor-support

add support for asyncioreactor with --reactor=asyncio

Author: altendky

appveyor.yml

@@ -14,22 +14,22 @@ environment:
     - TOXENV: py34-defaultreactor
       PYTHON: "C:\\Python34-x64"
 
-    - TOXENV: py35-defaultreactor, win-py35-qt5reactor
+    - TOXENV: py35-defaultreactor, win-py35-qt5reactor, py35-asyncioreactor
       PYTHON: "C:\\Python35"
 
-    - TOXENV: py35-defaultreactor, win-py35-qt5reactor
+    - TOXENV: py35-defaultreactor, win-py35-qt5reactor, py35-asyncioreactor
       PYTHON: "C:\\Python35-x64"
 
-    - TOXENV: py36-defaultreactor, win-py36-qt5reactor
+    - TOXENV: py36-defaultreactor, win-py36-qt5reactor, py36-asyncioreactor
       PYTHON: "C:\\Python36"
 
-    - TOXENV: py36-defaultreactor, win-py36-qt5reactor
+    - TOXENV: py36-defaultreactor, win-py36-qt5reactor, py36-asyncioreactor
       PYTHON: "C:\\Python36-x64"
 
-    - TOXENV: py37-defaultreactor, win-py37-qt5reactor
+    - TOXENV: py37-defaultreactor, win-py37-qt5reactor, py37-asyncioreactor
       PYTHON: "C:\\Python37"
 
-    - TOXENV: py37-defaultreactor, win-py37-qt5reactor
+    - TOXENV: py37-defaultreactor, win-py37-qt5reactor, py37-asyncioreactor
       PYTHON: "C:\\Python37-x64"
 
 install:

pytest_twisted.py

@@ -168,9 +168,19 @@ def init_qt5_reactor():
     )
 
 
+def init_asyncio_reactor():
+    from twisted.internet import asyncioreactor
+
+    _install_reactor(
+        reactor_installer=asyncioreactor.install,
+        reactor_type=asyncioreactor.AsyncioSelectorReactor,
+    )
+
+
 reactor_installers = {
     "default": init_default_reactor,
     "qt5reactor": init_qt5_reactor,
+    "asyncio": init_asyncio_reactor,
 }
 
 

testing/test_basic.py

@@ -447,3 +447,49 @@ def main():
     assert_outcomes(rr, {"passed": 1, "failed": 1})
     # test embedded mode:
     assert testdir.run(sys.executable, "runner.py").ret == 0
+
+
+def test_blockon_in_hook_with_asyncio(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "asyncio")
+    conftest_file = """
+    import pytest_twisted as pt
+    from twisted.internet import defer
+
+    def pytest_configure(config):
+        pt.init_asyncio_reactor()
+        d = defer.Deferred()
+
+        from twisted.internet import reactor
+
+        reactor.callLater(0.01, d.callback, 1)
+        pt.blockon(d)
+    """
+    testdir.makeconftest(conftest_file)
+    test_file = """
+    from twisted.internet import reactor, defer
+
+    def test_succeed():
+        d = defer.Deferred()
+        reactor.callLater(0.01, d.callback, 1)
+        return d
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(sys.executable, "-m", "pytest", "-v", *cmd_opts)
+    assert_outcomes(rr, {"passed": 1})
+
+
+def test_wrong_reactor_with_asyncio(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "asyncio")
+    conftest_file = """
+    def pytest_addhooks():
+        import twisted.internet.default
+        twisted.internet.default.install()
+    """
+    testdir.makeconftest(conftest_file)
+    test_file = """
+    def test_succeed():
+        pass
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(sys.executable, "-m", "pytest", "-v", *cmd_opts)
+    assert "WrongReactorAlreadyInstalledError" in rr.stderr.str()

tox.ini

@@ -1,7 +1,7 @@
 [tox]
 envlist=
     py{27,34}-defaultreactor
-    py{35,36,37}-{default,qt5}reactor
+    py{35,36,37}-{default,qt5,asyncio}reactor
     win-py{35,36,37}-qt5reactor
     linting
 
@@ -18,6 +18,7 @@ deps=
 commands=
     defaultreactor: pytest --reactor=default
     qt5reactor: pytest --reactor=qt5reactor
+    asyncioreactor: pytest --reactor=asyncio
 sitepackages=False
 
 [testenv:linting]