Merge branch 'master' into drop_qt5reactor_workaround

Author: altendky

README.rst

@@ -111,11 +111,6 @@ be explicitly installed earlier by calling
 ``pytest_twisted.init_default_reactor()`` or the corresponding function
 for the desired alternate reactor.
 
-Beware that in situations such as
-a ``conftest.py`` file that the name ``pytest_twisted`` may be
-undesirably detected by ``pytest`` as an unknown hook.  One alternative
-is to ``import pytest_twisted as pt``.
-
 
 inlineCallbacks
 ===============

setup.py

@@ -10,7 +10,7 @@
     long_description=long_description,
     long_description_content_type="text/x-rst",
     author="Ralf Schmitt, Kyle Altendorf, Victor Titor",
-    author_email="[email protected]",
+    author_email="[email protected]",
     url="https://github.com/pytest-dev/pytest-twisted",
     py_modules=["pytest_twisted"],
     python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',

testing/test_basic.py

@@ -665,16 +665,16 @@ async def test_doubleincrement(doubleincrement):
 def test_blockon_in_hook(testdir, cmd_opts, request):
     skip_if_reactor_not(request, "default")
     conftest_file = """
-    import pytest_twisted as pt
+    import pytest_twisted
     from twisted.internet import reactor, defer
 
     def pytest_configure(config):
-        pt.init_default_reactor()
+        pytest_twisted.init_default_reactor()
         d1, d2 = defer.Deferred(), defer.Deferred()
         reactor.callLater(0.01, d1.callback, 1)
         reactor.callLater(0.02, d2.callback, 1)
-        pt.blockon(d1)
-        pt.blockon(d2)
+        pytest_twisted.blockon(d1)
+        pytest_twisted.blockon(d2)
     """
     testdir.makeconftest(conftest_file)
     test_file = """
@@ -710,18 +710,18 @@ def test_succeed():
 def test_blockon_in_hook_with_qt5reactor(testdir, cmd_opts, request):
     skip_if_reactor_not(request, "qt5reactor")
     conftest_file = """
-    import pytest_twisted as pt
+    import pytest_twisted
     import pytestqt
     from twisted.internet import defer
 
     def pytest_configure(config):
-        pt.init_qt5_reactor()
+        pytest_twisted.init_qt5_reactor()
         d = defer.Deferred()
 
         from twisted.internet import reactor
 
         reactor.callLater(0.01, d.callback, 1)
-        pt.blockon(d)
+        pytest_twisted.blockon(d)
     """
     testdir.makeconftest(conftest_file)
     test_file = """
@@ -812,20 +812,20 @@ def test_blockon_in_hook_with_asyncio(testdir, cmd_opts, request):
     skip_if_reactor_not(request, "asyncio")
     conftest_file = """
     import pytest
-    import pytest_twisted as pt
+    import pytest_twisted
     from twisted.internet import defer
 
     @pytest.hookimpl(tryfirst=True)
     def pytest_configure(config):
-        pt._use_asyncio_selector_if_required(config=config)
+        pytest_twisted._use_asyncio_selector_if_required(config=config)
 
-        pt.init_asyncio_reactor()
+        pytest_twisted.init_asyncio_reactor()
         d = defer.Deferred()
 
         from twisted.internet import reactor
 
         reactor.callLater(0.01, d.callback, 1)
-        pt.blockon(d)
+        pytest_twisted.blockon(d)
     """
     testdir.makeconftest(conftest_file)
     test_file = """
@@ -912,3 +912,109 @@ def test_second(foo):
     testdir.makepyfile(test_file)
     rr = testdir.run(*cmd_opts, timeout=timeout)
     assert_outcomes(rr, {"passed": 2})
+
+
+def test_inlinecallbacks_method_with_fixture_gets_self(testdir, cmd_opts):
+    test_file = """
+    import pytest
+    import pytest_twisted
+    from twisted.internet import defer
+
+    @pytest.fixture
+    def foo():
+        return 37
+
+    class TestClass:
+        @pytest_twisted.inlineCallbacks
+        def test_self_isinstance(self, foo):
+            d = defer.succeed(None)
+            yield d
+            assert isinstance(self, TestClass)
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts)
+    assert_outcomes(rr, {"passed": 1})
+
+
+def test_inlinecallbacks_method_with_fixture_gets_fixture(testdir, cmd_opts):
+    test_file = """
+    import pytest
+    import pytest_twisted
+    from twisted.internet import defer
+
+    @pytest.fixture
+    def foo():
+        return 37
+
+    class TestClass:
+        @pytest_twisted.inlineCallbacks
+        def test_self_isinstance(self, foo):
+            d = defer.succeed(None)
+            yield d
+            assert foo == 37
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    assert_outcomes(rr, {"passed": 1})
+
+
+@skip_if_no_async_await()
+def test_ensuredeferred_method_with_fixture_gets_self(testdir, cmd_opts):
+    test_file = """
+    import pytest
+    import pytest_twisted
+
+    @pytest.fixture
+    def foo():
+        return 37
+
+    class TestClass:
+        @pytest_twisted.ensureDeferred
+        async def test_self_isinstance(self, foo):
+            assert isinstance(self, TestClass)
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    assert_outcomes(rr, {"passed": 1})
+
+
+@skip_if_no_async_await()
+def test_ensuredeferred_method_with_fixture_gets_fixture(testdir, cmd_opts):
+    test_file = """
+    import pytest
+    import pytest_twisted
+
+    @pytest.fixture
+    def foo():
+        return 37
+
+    class TestClass:
+        @pytest_twisted.ensureDeferred
+        async def test_self_isinstance(self, foo):
+            assert foo == 37
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    assert_outcomes(rr, {"passed": 1})
+
+
+def test_import_pytest_twisted_in_conftest_py_not_a_problem(testdir, cmd_opts):
+    conftest_file = """
+    import pytest
+    import pytest_twisted
+
+
+    @pytest.hookimpl(tryfirst=True)
+    def pytest_configure(config):
+        pytest_twisted._use_asyncio_selector_if_required(config=config)
+    """
+    testdir.makeconftest(conftest_file)
+    test_file = """
+    import pytest_twisted
+
+    def test_succeed():
+        pass
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    assert_outcomes(rr, {"passed": 1})