Merge branch 'master' into 35-altendky-tidy_async_await_fixtures

Author: altendky

README.rst

@@ -115,9 +115,9 @@ That's all.
    :alt: Travis build status
    :target: https://travis-ci.org/pytest-dev/pytest-twisted
 
-.. |AppVeyor| image:: https://ci.appveyor.com/api/projects/status/us5l0l9p7hyp2k6x/branch/master?svg=true
+.. |AppVeyor| image:: https://ci.appveyor.com/api/projects/status/eb1vp9hysp463c66/branch/master?svg=true
    :alt: AppVeyor build status
-   :target: https://ci.appveyor.com/project/vtitor/pytest-twisted
+   :target: https://ci.appveyor.com/project/pytestbot/pytest-twisted
 
 .. |Black| image:: https://img.shields.io/badge/code%20style-black-000000.svg
    :alt: Black code style

pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+filterwarnings = error

pytest_twisted.py

@@ -36,10 +36,6 @@ class _instances:
     reactor = None
 
 
-def pytest_namespace():
-    return {"inlineCallbacks": inlineCallbacks, "blockon": blockon}
-
-
 def blockon(d):
     if _config.external_reactor:
         return block_from_thread(d)
@@ -260,4 +256,6 @@ def pytest_addoption(parser):
 
 
 def pytest_configure(config):
+    pytest.inlineCallbacks = inlineCallbacks
+    pytest.blockon = blockon
     reactor_installers[config.getoption("reactor")]()

testing/test_basic.py

@@ -31,12 +31,10 @@ def format_run_result_output_for_assert(run_result):
     )
 
 
-def skip_if_reactor_not(expected_reactor):
-    actual_reactor = pytest.config.getoption("reactor", "default")
-    return pytest.mark.skipif(
-        actual_reactor != expected_reactor,
-        reason="reactor is {} not {}".format(actual_reactor, expected_reactor),
-    )
+def skip_if_reactor_not(request, expected_reactor):
+    actual_reactor = request.config.getoption("reactor", "default")
+    if actual_reactor != expected_reactor:
+        pytest.skip("reactor is {} not {}".format(actual_reactor, expected_reactor))
 
 
 def skip_if_no_async_await():
@@ -59,6 +57,14 @@ def cmd_opts(request):
     return ("--reactor={}".format(reactor),)
 
 
+def test_inline_callbacks_in_pytest():
+    assert hasattr(pytest, 'inlineCallbacks')
+
+
+def test_blockon_in_pytest():
+    assert hasattr(pytest, 'blockon')
+
+
 def test_fail_later(testdir, cmd_opts):
     test_file = """
     from twisted.internet import reactor, defer
@@ -284,8 +290,8 @@ def test_succeed(foo):
     assert_outcomes(rr, {"passed": 2, "failed": 3})
 
 
-@skip_if_reactor_not("default")
-def test_blockon_in_hook(testdir, cmd_opts):
+def test_blockon_in_hook(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "default")
     conftest_file = """
     import pytest_twisted as pt
     from twisted.internet import reactor, defer
@@ -312,8 +318,8 @@ def test_succeed():
     assert_outcomes(rr, {"passed": 1})
 
 
-@skip_if_reactor_not("default")
-def test_wrong_reactor(testdir, cmd_opts):
+def test_wrong_reactor(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "default")
     conftest_file = """
     def pytest_addhooks():
         import twisted.internet.reactor
@@ -329,8 +335,8 @@ def test_succeed():
     assert "WrongReactorAlreadyInstalledError" in rr.stderr.str()
 
 
-@skip_if_reactor_not("qt5reactor")
-def test_blockon_in_hook_with_qt5reactor(testdir, cmd_opts):
+def test_blockon_in_hook_with_qt5reactor(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "qt5reactor")
     conftest_file = """
     import pytest_twisted as pt
     import pytestqt
@@ -359,8 +365,8 @@ def test_succeed():
     assert_outcomes(rr, {"passed": 1})
 
 
-@skip_if_reactor_not("qt5reactor")
-def test_wrong_reactor_with_qt5reactor(testdir, cmd_opts):
+def test_wrong_reactor_with_qt5reactor(testdir, cmd_opts, request):
+    skip_if_reactor_not(request, "qt5reactor")
     conftest_file = """
     def pytest_addhooks():
         import twisted.internet.default
@@ -376,8 +382,8 @@ def test_succeed():
     assert "WrongReactorAlreadyInstalledError" in rr.stderr.str()
 
 
-@skip_if_reactor_not("default")
-def test_pytest_from_reactor_thread(testdir):
+def test_pytest_from_reactor_thread(testdir, request):
+    skip_if_reactor_not(request, "default")
     test_file = """
     import pytest
     import pytest_twisted

tox.ini

@@ -16,8 +16,8 @@ deps=
     qt5reactor: pyqt5
     win: pywin32
 commands=
-    defaultreactor: py.test --reactor=default
-    qt5reactor: py.test --reactor=qt5reactor
+    defaultreactor: pytest --reactor=default
+    qt5reactor: pytest --reactor=qt5reactor
 sitepackages=False
 
 [testenv:linting]