Skip to content

Commit 018acc6

Browse files
authored
Explain why thanks yourself in the CHANGELOG
1 parent 38e0e08 commit 018acc6

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,10 @@ Thanks for submitting a PR, your contribution is really appreciated!
22

33
Here's a quick checklist that should be present in PRs:
44

5-
- [ ] Target: for bug or doc fixes, target `master`; for new features, target `features`
6-
- [ ] Make sure to include one or more tests for your change
7-
- [ ] Add yourself to `AUTHORS`
8-
- [ ] Add a new entry to the `CHANGELOG` (choose any open position to avoid merge conflicts with other PRs)
5+
- [ ] Target: for bug or doc fixes, target `master`; for new features, target `features`;
6+
- [ ] Make sure to include one or more tests for your change;
7+
- [ ] Add yourself to `AUTHORS`;
8+
- [ ] Add a new entry to `CHANGELOG.rst`
9+
* Choose any open position to avoid merge conflicts with other PRs.
10+
* Add a link to the issue you are fixing (if any) using RST syntax.
11+
* The pytest team likes to have people to acknowledged in the `CHANGELOG`, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

0 commit comments

Comments
 (0)