Skip to content

Commit 03b24e5

Browse files
pprint: Remove the format method, it's not used outside of pprint
Let's reduce the API surface for the bundled PrettyPrinter to what we really need and use
1 parent 7541c5a commit 03b24e5

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

src/_pytest/_io/pprint.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -486,12 +486,7 @@ def _format_items(
486486
write("\n" + " " * indent)
487487

488488
def _repr(self, object: Any, context: Set[int], level: int) -> str:
489-
return self.format(object, context.copy(), self._depth, level)
490-
491-
def format(
492-
self, object: Any, context: Set[int], maxlevels: Optional[int], level: int
493-
) -> str:
494-
return self._safe_repr(object, context, maxlevels, level)
489+
return self._safe_repr(object, context.copy(), self._depth, level)
495490

496491
def _pprint_default_dict(
497492
self,
@@ -639,8 +634,8 @@ def _safe_repr(
639634
else:
640635
items = object.items()
641636
for k, v in items:
642-
krepr = self.format(k, context, maxlevels, level)
643-
vrepr = self.format(v, context, maxlevels, level)
637+
krepr = self._safe_repr(k, context, maxlevels, level)
638+
vrepr = self._safe_repr(v, context, maxlevels, level)
644639
append(f"{krepr}: {vrepr}")
645640
context.remove(objid)
646641
return "{%s}" % ", ".join(components)
@@ -668,7 +663,7 @@ def _safe_repr(
668663
append = components.append
669664
level += 1
670665
for o in object:
671-
orepr = self.format(o, context, maxlevels, level)
666+
orepr = self._safe_repr(o, context, maxlevels, level)
672667
append(orepr)
673668
context.remove(objid)
674669
return format % ", ".join(components)

0 commit comments

Comments
 (0)