Skip to content

Commit 196b173

Browse files
committed
address comments
1 parent 15156e9 commit 196b173

File tree

6 files changed

+121
-93
lines changed

6 files changed

+121
-93
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ jobs:
123123
with:
124124
fetch-depth: 0
125125
- name: Set up Python ${{ matrix.python }}
126-
# https://github.com/actions/setup-python/issues/171
127-
uses: actions/[email protected]
126+
uses: actions/setup-python@v2
128127
with:
129128
python-version: ${{ matrix.python }}
130129
- name: Install dependencies

src/_pytest/nodes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -528,7 +528,7 @@ def gethookproxy(self, fspath: "os.PathLike[str]"):
528528
warnings.warn(FSCOLLECTOR_GETHOOKPROXY_ISINITPATH, stacklevel=2)
529529
return self.session.gethookproxy(fspath)
530530

531-
def isinitpath(self, path: "os.PathLike[str]") -> bool:
531+
def isinitpath(self, path: Union[str, "os.PathLike[str]"]) -> bool:
532532
warnings.warn(FSCOLLECTOR_GETHOOKPROXY_ISINITPATH, stacklevel=2)
533533
return self.session.isinitpath(path)
534534

src/_pytest/python.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ def gethookproxy(self, fspath: "os.PathLike[str]"):
660660
warnings.warn(FSCOLLECTOR_GETHOOKPROXY_ISINITPATH, stacklevel=2)
661661
return self.session.gethookproxy(fspath)
662662

663-
def isinitpath(self, path: "os.PathLike[str]") -> bool:
663+
def isinitpath(self, path: Union[str, "os.PathLike[str]"]) -> bool:
664664
warnings.warn(FSCOLLECTOR_GETHOOKPROXY_ISINITPATH, stacklevel=2)
665665
return self.session.isinitpath(path)
666666

testing/test_debugging.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@
2121

2222

2323
@pytest.fixture(autouse=True)
24-
def pdb_env(request, monkeypatch: MonkeyPatch):
24+
def pdb_env(request):
2525
if "pytester" in request.fixturenames:
2626
# Disable pdb++ with inner tests.
27-
monkeypatch.setenv("PDBPP_HIJACK_PDB", "0")
27+
pytester = request.getfixturevalue("pytester")
28+
pytester._monkeypatch.setenv("PDBPP_HIJACK_PDB", "0")
2829

2930

3031
def runpdb_and_get_report(pytester: Pytester, source: str):

0 commit comments

Comments
 (0)