minor: LFPlugin: de-indent code by returning if not active

Author: blueyed

src/_pytest/cacheprovider.py

@@ -179,45 +179,45 @@ def pytest_collectreport(self, report):
             self.lastfailed[report.nodeid] = True
 
     def pytest_collection_modifyitems(self, session, config, items):
-        if self.active:
-            if self.lastfailed:
-                previously_failed = []
-                previously_passed = []
-                for item in items:
-                    if item.nodeid in self.lastfailed:
-                        previously_failed.append(item)
-                    else:
-                        previously_passed.append(item)
-                self._previously_failed_count = len(previously_failed)
-
-                if not previously_failed:
-                    # Running a subset of all tests with recorded failures
-                    # only outside of it.
-                    self._report_status = "%d known failures not in selected tests" % (
-                        len(self.lastfailed),
-                    )
+        if not self.active:
+            return
+
+        if self.lastfailed:
+            previously_failed = []
+            previously_passed = []
+            for item in items:
+                if item.nodeid in self.lastfailed:
+                    previously_failed.append(item)
                 else:
-                    if self.config.getoption("lf"):
-                        items[:] = previously_failed
-                        config.hook.pytest_deselected(items=previously_passed)
-                    else:  # --failedfirst
-                        items[:] = previously_failed + previously_passed
-
-                    noun = (
-                        "failure" if self._previously_failed_count == 1 else "failures"
-                    )
-                    suffix = " first" if self.config.getoption("failedfirst") else ""
-                    self._report_status = "rerun previous {count} {noun}{suffix}".format(
-                        count=self._previously_failed_count, suffix=suffix, noun=noun
-                    )
+                    previously_passed.append(item)
+            self._previously_failed_count = len(previously_failed)
+
+            if not previously_failed:
+                # Running a subset of all tests with recorded failures
+                # only outside of it.
+                self._report_status = "%d known failures not in selected tests" % (
+                    len(self.lastfailed),
+                )
             else:
-                self._report_status = "no previously failed tests, "
-                if self.config.getoption("last_failed_no_failures") == "none":
-                    self._report_status += "deselecting all items."
-                    config.hook.pytest_deselected(items=items)
-                    items[:] = []
-                else:
-                    self._report_status += "not deselecting items."
+                if self.config.getoption("lf"):
+                    items[:] = previously_failed
+                    config.hook.pytest_deselected(items=previously_passed)
+                else:  # --failedfirst
+                    items[:] = previously_failed + previously_passed
+
+                noun = "failure" if self._previously_failed_count == 1 else "failures"
+                suffix = " first" if self.config.getoption("failedfirst") else ""
+                self._report_status = "rerun previous {count} {noun}{suffix}".format(
+                    count=self._previously_failed_count, suffix=suffix, noun=noun
+                )
+        else:
+            self._report_status = "no previously failed tests, "
+            if self.config.getoption("last_failed_no_failures") == "none":
+                self._report_status += "deselecting all items."
+                config.hook.pytest_deselected(items=items)
+                items[:] = []
+            else:
+                self._report_status += "not deselecting items."
 
     def pytest_sessionfinish(self, session):
         config = self.config