13403: Disable assertion rewriting for external modules - refactor

Author: Tusenka

src/_pytest/assertion/__init__.py

@@ -108,7 +108,16 @@ def __init__(self, config: Config, mode) -> None:
         self.mode = mode
         self.trace = config.trace.root.get("assertion")
         self.hook: rewrite.AssertionRewritingHook | None = None
-        self.root_path=os.getcwd()
+
+    @property
+    def root_path(self):
+        try:
+            return os.getcwd()
+        except FileNotFoundError:
+            # Fixes for py's trying to os.getcwd() on py34
+            # when current working directory doesn't exist (previously triggered via xdist only).
+            # Ref: https://github.com/pytest-dev/py/pull/207
+            return os.path.dirname(os.path.abspath(sys.argv[0]))
 
 def install_importhook(config: Config) -> rewrite.AssertionRewritingHook:
     """Try to install the rewrite hook, raise SystemError if it fails."""

testing/test_assertrewrite.py

@@ -1900,7 +1900,6 @@ def hook(
         if PathFinder.find_spec has been called.
         """
         import importlib.machinery
-
         self.find_spec_calls: list[str] = []
         self.initial_paths: set[Path] = set()
 
@@ -1974,6 +1973,7 @@ def test_simple_failure():
             assert hook.find_spec("file") is not None
             assert self.find_spec_calls == ["file"]
 
+
     def test_assert_excluded_rootpath(
         self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
     ) -> None:
@@ -1988,12 +1988,26 @@ def test_simple_failure():
                 """
             }
         )
+        with mock.patch.object(hook, "fnpats", ["*.py"]):
+            assert hook.find_spec("file") is not None
         root_path = f"{os.getcwd()}/tests"
-        mkdir(root_path)
+
+        if not os.path.exists(root_path):
+           mkdir(root_path)
         monkeypatch.chdir(root_path)
         with mock.patch.object(hook, "fnpats", ["*.py"]):
             assert hook.find_spec("file") is None
 
+
+    def test_assert_excluded_rewrite_for_plugins(
+        self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
+    ) -> None:
+        plugins= {"ayncio", "fnpats", "pytest_bdd", "django", "mock", "pytest_twisted", "trio"}
+        with mock.patch.object(hook, "fnpats", ["*.py"]):
+            for plugin in plugins:
+                assert hook.find_spec(plugin) is None
+
+
     @pytest.mark.skipif(
         sys.platform.startswith("win32"), reason="cannot remove cwd on Windows"
     )