13403: Disable assertion rewriting for external modules - add tests

Author: Tusenka

src/_pytest/assertion/__init__.py

@@ -110,7 +110,10 @@ def __init__(self, config: Config, mode) -> None:
         self.hook: rewrite.AssertionRewritingHook | None = None
 
     @property
-    def root_path(self):
+    def rootpath(self):
+        """
+        get current root path (current working dir)
+        """
         try:
             return os.getcwd()
         except FileNotFoundError:

src/_pytest/assertion/rewrite.py

@@ -218,7 +218,6 @@ def _early_rewrite_bailout(self, name: str, state: AssertionState) -> bool:
             if fnmatch_ex(pat, path):
                 return False
 
-
         if self._is_marked_for_rewrite(name, state):
             return False
 
@@ -241,7 +240,7 @@ def _should_rewrite(self, name: str, fn: str, state: AssertionState) -> bool:
         fn_path = PurePath(fn)
 
         for pat in self.fnpats:
-            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to(state.root_path):
+            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to(state.rootpath):
                 state.trace(f"matched test file {fn!r}")
                 return True
 

testing/test_assertrewrite.py

@@ -1974,11 +1974,11 @@ def test_simple_failure():
             assert self.find_spec_calls == ["file"]
 
 
-    def test_assert_excluded_rootpath(
+    def test_assert_rewrites_only_rootpath(
         self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
     ) -> None:
         """
-        If test files contained outside rootdir, then skip them
+        If test files contained outside the rootpath, then skip them
         """
         pytester.makepyfile(
             **{
@@ -1990,22 +1990,58 @@ def test_simple_failure():
         )
         with mock.patch.object(hook, "fnpats", ["*.py"]):
             assert hook.find_spec("file") is not None
-        root_path = f"{os.getcwd()}/tests"
 
-        if not os.path.exists(root_path):
-           mkdir(root_path)
-        monkeypatch.chdir(root_path)
+        rootpath = f"{os.getcwd()}/tests"
+        if not os.path.exists(rootpath):
+           mkdir(rootpath)
+        monkeypatch.chdir(rootpath)
         with mock.patch.object(hook, "fnpats", ["*.py"]):
             assert hook.find_spec("file") is None
 
 
+    def test_assert_correct_for_conftfest(
+        self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
+    ) -> None:
+        """
+        Conftest is always rewritten regardless of the working dir
+        """
+        pytester.makeconftest(
+            """
+            import pytest
+            @pytest.fixture
+            def fix(): return 1
+        """
+        )
+
+        rootpath = f"{os.getcwd()}/tests"
+        if not os.path.exists(rootpath):
+           mkdir(rootpath)
+        monkeypatch.chdir(rootpath)
+
+        with mock.patch.object(hook, "fnpats", ["*.py"]):
+            assert hook.find_spec("conftest") is not None
+            
+
     def test_assert_excluded_rewrite_for_plugins(
         self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
     ) -> None:
-        plugins= {"ayncio", "fnpats", "pytest_bdd", "django", "mock", "pytest_twisted", "trio"}
+        pkgdir = pytester.mkpydir("plugin")
+        pkgdir.joinpath("__init__.py").write_text(
+            "import pytest\n"
+            "@pytest.fixture\n"
+            "def special_asserter():\n"
+            "    def special_assert(x, y):\n"
+            "        assert x == y\n"
+            "    return special_assert\n",
+            encoding="utf-8",
+        )
+        pytester.makeconftest('pytest_plugins = ["plugin"]')
+        rootpath = f"{os.getcwd()}/tests"
+        if not os.path.exists(rootpath):
+            mkdir(rootpath)
+        monkeypatch.chdir(rootpath)
         with mock.patch.object(hook, "fnpats", ["*.py"]):
-            for plugin in plugins:
-                assert hook.find_spec(plugin) is None
+            assert hook.find_spec("plugin") is not None
 
 
     @pytest.mark.skipif(