Skip to content

Commit 3c1f8b4

Browse files
fixup: undo accidential name-mangling in the junitxml test helpers
1 parent ba12313 commit 3c1f8b4

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

testing/test_junitxml.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ def nodeval(node: minidom.Element, name: str) -> str | None:
7777

7878
class DomDocument:
7979
def __init__(self, dom: minidom.Document):
80-
self.__node = dom
80+
self._node = dom
8181

82-
__node: minidom.Document
82+
_node: minidom.Document | minidom.Element
8383

8484
def find_first_by_tag(self, tag: str) -> DomNode | None:
8585
return self.find_nth_by_tag(tag, 0)
@@ -92,7 +92,7 @@ def get_first_by_tag(self, tag: str) -> DomNode:
9292
return maybe
9393

9494
def find_nth_by_tag(self, tag: str, n: int) -> DomNode | None:
95-
items = self.__node.getElementsByTagName(tag)
95+
items = self._node.getElementsByTagName(tag)
9696
try:
9797
nth = items[n]
9898
except IndexError:
@@ -101,11 +101,11 @@ def find_nth_by_tag(self, tag: str, n: int) -> DomNode | None:
101101
return DomNode(nth)
102102

103103
def find_by_tag(self, tag: str) -> list[DomNode]:
104-
return [DomNode(x) for x in self.__node.getElementsByTagName(tag)]
104+
return [DomNode(x) for x in self._node.getElementsByTagName(tag)]
105105

106106
@property
107107
def children(self) -> list[DomNode]:
108-
return [DomNode(x) for x in self.__node.childNodes]
108+
return [DomNode(x) for x in self._node.childNodes]
109109

110110
@property
111111
def get_unique_child(self) -> DomNode:
@@ -114,40 +114,40 @@ def get_unique_child(self) -> DomNode:
114114
return children[0]
115115

116116
def toxml(self) -> str:
117-
return self.__node.toxml()
117+
return self._node.toxml()
118118

119119

120120
class DomNode(DomDocument):
121-
__node: minidom.Element
121+
_node: minidom.Element
122122

123123
def __init__(self, dom: minidom.Element):
124-
self.__node = dom
124+
self._node = dom
125125

126126
def __repr__(self) -> str:
127127
return self.toxml()
128128

129129
def __getitem__(self, key: str) -> str:
130-
node = self.__node.getAttributeNode(key)
130+
node = self._node.getAttributeNode(key)
131131
if node is not None:
132132
return cast(str, node.value)
133133
else:
134134
raise KeyError(key)
135135

136136
def assert_attr(self, **kwargs: object) -> None:
137137
__tracebackhide__ = True
138-
return assert_attr(self.__node, **kwargs)
138+
return assert_attr(self._node, **kwargs)
139139

140140
@property
141141
def text(self) -> str:
142-
return cast(str, self.__node.childNodes[0].wholeText)
142+
return cast(str, self._node.childNodes[0].wholeText)
143143

144144
@property
145145
def tag(self) -> str:
146-
return self.__node.tagName
146+
return self._node.tagName
147147

148148
@property
149149
def next_sibling(self) -> DomNode:
150-
return DomNode(self.__node.nextSibling)
150+
return DomNode(self._node.nextSibling)
151151

152152

153153
parametrize_families = pytest.mark.parametrize("xunit_family", ["xunit1", "xunit2"])

0 commit comments

Comments
 (0)