Skip to content

Commit 3c69bc9

Browse files
committed
python: remove broken/ineffectual keywords marks initialization
By my analysis, this deleted code block has no effect: 1. `self.keywords` is `update`d with `callspec.marks`. 2. `self.own_markers` is `update`d with `callspec.marks`. 3. `self.keywords` is `update`d with `self.own_markers`. So together steps 2+3 completely undo step 1.
1 parent d9bcfa0 commit 3c69bc9

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

src/_pytest/python.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,13 +1662,6 @@ def __init__(
16621662
self.own_markers.extend(get_unpacked_marks(self.obj))
16631663
if callspec:
16641664
self.callspec = callspec
1665-
# this is total hostile and a mess
1666-
# keywords are broken by design by now
1667-
# this will be redeemed later
1668-
for mark in callspec.marks:
1669-
# feel free to cry, this was broken for years before
1670-
# and keywords can't fix it per design
1671-
self.keywords[mark.name] = mark
16721665
self.own_markers.extend(callspec.marks)
16731666
if keywords:
16741667
self.keywords.update(keywords)

0 commit comments

Comments
 (0)