Skip to content

Commit 44bf7a2

Browse files
authored
Mark some xfails from #10042 as non-strict (#11832)
Related to #10042, some tests in `test_debugging.py` are actually flaky and should not be considered strict xfailures.
1 parent 2144052 commit 44bf7a2

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

testing/test_debugging.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ def test_pdb_prevent_ConftestImportFailure_hiding_exception(
372372
result = pytester.runpytest_subprocess("--pdb", ".")
373373
result.stdout.fnmatch_lines(["-> import unknown"])
374374

375-
@pytest.mark.xfail(reason="#10042")
375+
@pytest.mark.xfail(reason="#10042", strict=False)
376376
def test_pdb_interaction_capturing_simple(self, pytester: Pytester) -> None:
377377
p1 = pytester.makepyfile(
378378
"""
@@ -541,7 +541,7 @@ def function_1():
541541
assert "BdbQuit" not in rest
542542
assert "UNEXPECTED EXCEPTION" not in rest
543543

544-
@pytest.mark.xfail(reason="#10042")
544+
@pytest.mark.xfail(reason="#10042", strict=False)
545545
def test_pdb_interaction_capturing_twice(self, pytester: Pytester) -> None:
546546
p1 = pytester.makepyfile(
547547
"""
@@ -577,7 +577,7 @@ def test_1():
577577
assert "1 failed" in rest
578578
self.flush(child)
579579

580-
@pytest.mark.xfail(reason="#10042")
580+
@pytest.mark.xfail(reason="#10042", strict=False)
581581
def test_pdb_with_injected_do_debug(self, pytester: Pytester) -> None:
582582
"""Simulates pdbpp, which injects Pdb into do_debug, and uses
583583
self.__class__ in do_continue.
@@ -1022,7 +1022,7 @@ def test_1():
10221022
assert "reading from stdin while output" not in rest
10231023
TestPDB.flush(child)
10241024

1025-
@pytest.mark.xfail(reason="#10042")
1025+
@pytest.mark.xfail(reason="#10042", strict=False)
10261026
def test_pdb_not_altered(self, pytester: Pytester) -> None:
10271027
p1 = pytester.makepyfile(
10281028
"""
@@ -1182,7 +1182,7 @@ def test_2():
11821182

11831183

11841184
@pytest.mark.parametrize("fixture", ("capfd", "capsys"))
1185-
@pytest.mark.xfail(reason="#10042")
1185+
@pytest.mark.xfail(reason="#10042", strict=False)
11861186
def test_pdb_suspends_fixture_capturing(pytester: Pytester, fixture: str) -> None:
11871187
"""Using "-s" with pytest should suspend/resume fixture capturing."""
11881188
p1 = pytester.makepyfile(

0 commit comments

Comments
 (0)