Skip to content

Commit 4e58c9a

Browse files
committed
Fix use of deprecated getfuncargvalue method in the internal doctest plugin
Fix #1898
1 parent a9f3053 commit 4e58c9a

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,21 @@
2121
enabled. This allows proper post mortem debugging for all applications
2222
which have significant logic in their tearDown machinery (`#1890`_). Thanks
2323
`@mbyt`_ for the PR.
24+
25+
* Fix use of deprecated ``getfuncargvalue`` method in the internal doctest plugin.
26+
Thanks `@ViviCoder`_ for the report (`#1898`_).
2427

2528
.. _@joguSD: https://github.com/joguSD
2629
.. _@AiOO: https://github.com/AiOO
2730
.. _@mbyt: https://github.com/mbyt
31+
.. _@ViviCoder: https://github.com/ViviCoder
2832

2933
.. _#1857: https://github.com/pytest-dev/pytest/issues/1857
3034
.. _#1864: https://github.com/pytest-dev/pytest/issues/1864
3135
.. _#1888: https://github.com/pytest-dev/pytest/issues/1888
3236
.. _#1891: https://github.com/pytest-dev/pytest/pull/1891
3337
.. _#1890: https://github.com/pytest-dev/pytest/issues/1890
38+
.. _#1898: https://github.com/pytest-dev/pytest/issues/1898
3439

3540

3641
3.0.1

_pytest/doctest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ def setup(self):
8888
if self.dtest is not None:
8989
self.fixture_request = _setup_fixtures(self)
9090
globs = dict(getfixture=self.fixture_request.getfixturevalue)
91-
for name, value in self.fixture_request.getfuncargvalue('doctest_namespace').items():
91+
for name, value in self.fixture_request.getfixturevalue('doctest_namespace').items():
9292
globs[name] = value
9393
self.dtest.globs.update(globs)
9494

0 commit comments

Comments
 (0)