Skip to content

Commit 5c4a9c5

Browse files
fixup: undo accidential name-mangling in the junitxml test helpers
1 parent 31ccb8a commit 5c4a9c5

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

testing/test_junitxml.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,9 @@ def nodeval(node: minidom.Element, name: str) -> str | None:
7676

7777
class DomDocument:
7878
def __init__(self, dom: minidom.Document):
79-
self.__node = dom
79+
self._node = dom
8080

81-
__node: minidom.Document
81+
_node: minidom.Document | minidom.Element
8282

8383
def find_first_by_tag(self, tag: str) -> DomNode | None:
8484
return self.find_nth_by_tag(tag, 0)
@@ -91,7 +91,7 @@ def get_first_by_tag(self, tag: str) -> DomNode:
9191
return maybe
9292

9393
def find_nth_by_tag(self, tag: str, n: int) -> DomNode | None:
94-
items = self.__node.getElementsByTagName(tag)
94+
items = self._node.getElementsByTagName(tag)
9595
try:
9696
nth = items[n]
9797
except IndexError:
@@ -100,11 +100,11 @@ def find_nth_by_tag(self, tag: str, n: int) -> DomNode | None:
100100
return DomNode(nth)
101101

102102
def find_by_tag(self, tag: str) -> list[DomNode]:
103-
return [DomNode(x) for x in self.__node.getElementsByTagName(tag)]
103+
return [DomNode(x) for x in self._node.getElementsByTagName(tag)]
104104

105105
@property
106106
def children(self) -> list[DomNode]:
107-
return [DomNode(x) for x in self.__node.childNodes]
107+
return [DomNode(x) for x in self._node.childNodes]
108108

109109
@property
110110
def get_unique_child(self) -> DomNode:
@@ -113,40 +113,40 @@ def get_unique_child(self) -> DomNode:
113113
return children[0]
114114

115115
def toxml(self) -> str:
116-
return self.__node.toxml()
116+
return self._node.toxml()
117117

118118

119119
class DomNode(DomDocument):
120-
__node: minidom.Element
120+
_node: minidom.Element
121121

122122
def __init__(self, dom: minidom.Element):
123-
self.__node = dom
123+
self._node = dom
124124

125125
def __repr__(self) -> str:
126126
return self.toxml()
127127

128128
def __getitem__(self, key: str) -> str:
129-
node = self.__node.getAttributeNode(key)
129+
node = self._node.getAttributeNode(key)
130130
if node is not None:
131131
return cast(str, node.value)
132132
else:
133133
raise KeyError(key)
134134

135135
def assert_attr(self, **kwargs: object) -> None:
136136
__tracebackhide__ = True
137-
return assert_attr(self.__node, **kwargs)
137+
return assert_attr(self._node, **kwargs)
138138

139139
@property
140140
def text(self) -> str:
141-
return cast(str, self.__node.childNodes[0].wholeText)
141+
return cast(str, self._node.childNodes[0].wholeText)
142142

143143
@property
144144
def tag(self) -> str:
145-
return self.__node.tagName
145+
return self._node.tagName
146146

147147
@property
148148
def next_sibling(self) -> DomNode:
149-
return DomNode(self.__node.nextSibling)
149+
return DomNode(self._node.nextSibling)
150150

151151

152152
parametrize_families = pytest.mark.parametrize("xunit_family", ["xunit1", "xunit2"])

0 commit comments

Comments
 (0)