un-iterable fix

Author: reaganjlee

changelog/7966.bugfix.rst

@@ -0,0 +1 @@
+Removes unhelpful error message from assertion rewrite mechanism when exceptions raised in __iter__ methods, and instead treats them as un-iterable.

src/_pytest/assertion/util.py

@@ -132,7 +132,7 @@ def isiterable(obj: Any) -> bool:
     try:
         iter(obj)
         return not istext(obj)
-    except TypeError:
+    except Exception:
         return False
 
 

testing/test_assertrewrite.py

@@ -689,16 +689,19 @@ def test_assert_handling_raise_in__iter__(self) -> None:
         def f() -> None:
             class A:
                 def __iter__(self):
-                    raise TypeError("user message")
+                    raise ValueError()
 
                 def __eq__(self, o: object) -> bool:
                     return self is o
 
+                def __repr__(self):
+                    return "<A object>"
+
             assert A() == A()
 
         msg = getmsg(f)
         assert msg is not None
-        assert "Unexpected exception" in msg
+        assert "<A object> == <A object>" in msg
 
     def test_formatchar(self) -> None:
         def f() -> None: