Skip to content

Commit 6242777

Browse files
authored
Merge pull request #6041 from blueyed/pytester-splitlines
pytester: runpytest_inprocess: use splitlines()
2 parents 20ee883 + 2f589a9 commit 6242777

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/_pytest/pytester.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -881,7 +881,9 @@ class reprec:
881881
sys.stdout.write(out)
882882
sys.stderr.write(err)
883883

884-
res = RunResult(reprec.ret, out.split("\n"), err.split("\n"), time.time() - now)
884+
res = RunResult(
885+
reprec.ret, out.splitlines(), err.splitlines(), time.time() - now
886+
)
885887
res.reprec = reprec
886888
return res
887889

testing/test_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1291,7 +1291,7 @@ def test_config_blocked_default_plugins(testdir, plugin):
12911291
if plugin != "terminal":
12921292
result.stdout.fnmatch_lines(["* 1 failed in *"])
12931293
else:
1294-
assert result.stdout.lines == [""]
1294+
assert result.stdout.lines == []
12951295

12961296

12971297
class TestSetupCfg:

testing/test_runner.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ def test_foo():
597597
result = testdir.runpytest()
598598
result.stdout.fnmatch_lines(["*! *Exit: some exit msg !*"])
599599

600-
assert _strip_resource_warnings(result.stderr.lines) == [""]
600+
assert _strip_resource_warnings(result.stderr.lines) == []
601601
assert result.ret == 99
602602

603603
# It prints to stderr also in case of exit during pytest_sessionstart.
@@ -612,8 +612,7 @@ def pytest_sessionstart():
612612
result = testdir.runpytest()
613613
result.stdout.fnmatch_lines(["*! *Exit: during_sessionstart !*"])
614614
assert _strip_resource_warnings(result.stderr.lines) == [
615-
"Exit: during_sessionstart",
616-
"",
615+
"Exit: during_sessionstart"
617616
]
618617
assert result.ret == 98
619618

0 commit comments

Comments
 (0)