mypy

Author: aaronzo

src/_pytest/recwarn.py

@@ -8,6 +8,7 @@
 from types import TracebackType
 from typing import Any
 from typing import Callable
+from typing import cast
 from typing import final
 from typing import Generator
 from typing import Iterator
@@ -260,10 +261,11 @@ def __enter__(self) -> Self:
 
         if self._keep_ignores:
             for action, message, category, module, lineno in warnings.filters:
-                kw = {}
+                kw: dict[str, str] = {}
                 if isinstance(message, str):
                     kw.update(message=message)
                 if module is not None:
+                    module = cast(str, re.Pattern, module)
                     if isinstance(module, re.Pattern):
                         module = getattr(module, "pattern", None)
                     if isinstance(module, str):

testing/test_recwarn.py

@@ -405,13 +405,13 @@ def test_match_regex(self) -> None:
                     warnings.warn("value must be 42", UserWarning)
 
     def test_keep_ignores(self) -> None:
-        with warnings.catch_warnings:
+        with warnings.catch_warnings():
             warnings.filterwarnings("error", category=UserWarning)
             with pytest.warns(UserWarning, keep_ignores=True):
                 warnings.warn("keep this warning", UserWarning)
 
         with pytest.raises(pytest.fail.Exception, match="DID NOT WARN"):
-            with warnings.catch_warnings:
+            with warnings.catch_warnings():
                 warnings.filterwarnings("ignore", message="ignore this")
                 with pytest.warns(UserWarning, keep_ignores=True):
                     warnings.warn("ignore this warning", FutureWarning)