Make wasxfail consistent (#13328)

Previously, xfailed tests via the marker would have a special `"reason: "` string prefixed to it. 

Removed the prefix so the `wasxfail` attribute is now consistent regardless the method used.

Fix #11067

---------

Co-authored-by: Bruno Oliveira <[email protected]>

Author: harmin-parra

changelog/11067.bugfix.rst

@@ -0,0 +1,3 @@
+The test report is now consistent regardless if the test xfailed via :ref:`pytest.mark.xfail <pytest.mark.xfail ref>` or :func:`pytest.fail`.
+
+Previously, *xfailed* tests via the marker would have the string ``"reason: "`` prefixed to the message, while those *xfailed* via the function did not. The prefix has been removed.

src/_pytest/skipping.py

@@ -278,7 +278,7 @@ def pytest_runtest_makereport(
         pass  # don't interfere
     elif call.excinfo and isinstance(call.excinfo.value, xfail.Exception):
         assert call.excinfo.value.msg is not None
-        rep.wasxfail = "reason: " + call.excinfo.value.msg
+        rep.wasxfail = call.excinfo.value.msg
         rep.outcome = "skipped"
     elif not rep.skipped and xfailed:
         if call.excinfo:

testing/test_skipping.py

@@ -448,8 +448,8 @@ def test_this_false():
         result = pytester.runpytest(p, "-rx")
         result.stdout.fnmatch_lines(
             [
-                "*test_one*test_this - reason: *NOTRUN* noway",
-                "*test_one*test_this_true - reason: *NOTRUN* condition: True",
+                "*test_one*test_this - *NOTRUN* noway",
+                "*test_one*test_this_true - *NOTRUN* condition: True",
                 "*1 passed*",
             ]
         )
@@ -492,7 +492,7 @@ def test_this():
         result = pytester.runpytest(p)
         result.stdout.fnmatch_lines(["*1 xfailed*"])
         result = pytester.runpytest(p, "-rx")
-        result.stdout.fnmatch_lines(["*XFAIL*test_this*reason:*hello*"])
+        result.stdout.fnmatch_lines(["*XFAIL*test_this*hello*"])
         result = pytester.runpytest(p, "--runxfail")
         result.stdout.fnmatch_lines(["*1 pass*"])
 
@@ -510,7 +510,7 @@ def test_this():
         result = pytester.runpytest(p)
         result.stdout.fnmatch_lines(["*1 xfailed*"])
         result = pytester.runpytest(p, "-rx")
-        result.stdout.fnmatch_lines(["*XFAIL*test_this*reason:*hello*"])
+        result.stdout.fnmatch_lines(["*XFAIL*test_this*hello*"])
         result = pytester.runpytest(p, "--runxfail")
         result.stdout.fnmatch_lines(
             """