Fixed color inconsistency in verbose mode where test status showed green instead of yellow for passed tests with warnings.

Author: treyshaffer

AUTHORS

@@ -463,6 +463,7 @@ Tomer Keren
 Tony Narlock
 Tor Colvin
 Trevor Bekolay
+Trey Shaffer
 Tushar Sadhwani
 Tyler Goodlet
 Tyler Smart

changelog/13201.bugfix.rst

@@ -0,0 +1 @@
+Fixed color inconsistency in verbose mode where test status showed green instead of yellow for passed tests with warnings.

src/_pytest/terminal.py

@@ -635,10 +635,16 @@ def pytest_runtest_logreport(self, report: TestReport) -> None:
             return
         if markup is None:
             was_xfail = hasattr(report, "wasxfail")
-            if rep.passed and not was_xfail:
-                markup = {"green": True}
-            elif rep.passed and was_xfail:
-                markup = {"yellow": True}
+            has_warnings = any(
+                name == "has_warnings" and value
+                for name, value in getattr(report, "user_properties", [])
+            )
+
+            if rep.passed:
+                if was_xfail or has_warnings:
+                    markup = {"yellow": True}
+                else:
+                    markup = {"green": True}
             elif rep.failed:
                 markup = {"red": True}
             elif rep.skipped:

src/_pytest/warnings.py

@@ -6,18 +6,28 @@
 from contextlib import ExitStack
 import sys
 from typing import Literal
+from typing import TYPE_CHECKING
 import warnings
 
 from _pytest.config import apply_warning_filters
 from _pytest.config import Config
 from _pytest.config import parse_warning_filter
 from _pytest.main import Session
 from _pytest.nodes import Item
+from _pytest.stash import StashKey
 from _pytest.terminal import TerminalReporter
 from _pytest.tracemalloc import tracemalloc_message
 import pytest
 
 
+if TYPE_CHECKING:
+    from _pytest.reports import TestReport
+    from _pytest.runner import CallInfo
+
+# StashKey for storing warning log on items
+warning_captured_log_key = StashKey[list[warnings.WarningMessage]]()
+
+
 @contextmanager
 def catch_warnings_for_item(
     config: Config,
@@ -51,6 +61,9 @@ def catch_warnings_for_item(
             for mark in item.iter_markers(name="filterwarnings"):
                 for arg in mark.args:
                     warnings.filterwarnings(*parse_warning_filter(arg, escape=False))
+            # Store the warning log on the item so it can be accessed during reporting
+            if record and log is not None:
+                item.stash[warning_captured_log_key] = log
 
         try:
             yield
@@ -89,6 +102,20 @@ def pytest_runtest_protocol(item: Item) -> Generator[None, object, object]:
         return (yield)
 
 
+@pytest.hookimpl(hookwrapper=True)
+def pytest_runtest_makereport(
+    item: Item, call: CallInfo[None]
+) -> Generator[None, TestReport, None]:
+    """Attach warning information to test reports for terminal coloring."""
+    outcome = yield
+    report: TestReport = outcome.get_result()
+
+    if report.passed and report.when == "call":
+        warning_log = item.stash.get(warning_captured_log_key, None)
+        if warning_log:
+            report.user_properties.append(("has_warnings", True))
+
+
 @pytest.hookimpl(wrapper=True, tryfirst=True)
 def pytest_collection(session: Session) -> Generator[None, object, object]:
     config = session.config

testing/test_terminal.py

@@ -2191,7 +2191,7 @@ def test_foobar(i): raise ValueError()
                 [
                     r"test_axfail.py {yellow}x{reset}{green} \s+ \[  4%\]{reset}",
                     r"test_bar.py ({green}\.{reset}){{10}}{green} \s+ \[ 52%\]{reset}",
-                    r"test_foo.py ({green}\.{reset}){{5}}{yellow} \s+ \[ 76%\]{reset}",
+                    r"test_foo.py ({yellow}\.{reset}){{5}}{yellow} \s+ \[ 76%\]{reset}",
                     r"test_foobar.py ({red}F{reset}){{5}}{red} \s+ \[100%\]{reset}",
                 ]
             )
@@ -2208,6 +2208,65 @@ def test_foobar(i): raise ValueError()
             )
         )
 
+    def test_verbose_colored_warnings(
+        self, pytester: Pytester, monkeypatch, color_mapping
+    ) -> None:
+        """Test that verbose mode shows yellow PASSED for tests with warnings."""
+        monkeypatch.setenv("PY_COLORS", "1")
+        pytester.makepyfile(
+            test_warning="""
+                import warnings
+                def test_with_warning():
+                    warnings.warn("test warning", DeprecationWarning)
+                    pass
+
+                def test_without_warning():
+                    pass
+            """
+        )
+        result = pytester.runpytest("-v")
+        result.stdout.re_match_lines(
+            color_mapping.format_for_rematch(
+                [
+                    r"test_warning.py::test_with_warning {yellow}PASSED{reset}{green} \s+ \[ 50%\]{reset}",
+                    r"test_warning.py::test_without_warning {green}PASSED{reset}{yellow} \s+ \[100%\]{reset}",
+                ]
+            )
+        )
+
+    def test_verbose_colored_warnings_xdist(
+        self, pytester: Pytester, monkeypatch, color_mapping
+    ) -> None:
+        """Test that warning coloring works correctly with pytest-xdist parallel execution."""
+        pytest.importorskip("xdist")
+        monkeypatch.setenv("PY_COLORS", "1")
+        pytester.makepyfile(
+            test_warning_xdist="""
+                import warnings
+                def test_with_warning_1():
+                    warnings.warn("warning in test 1", DeprecationWarning)
+                    pass
+
+                def test_with_warning_2():
+                    warnings.warn("warning in test 2", DeprecationWarning)
+                    pass
+
+                def test_without_warning():
+                    pass
+            """
+        )
+
+        output = pytester.runpytest("-v", "-n2")
+        output.stdout.re_match_lines(
+            color_mapping.format_for_rematch(
+                [
+                    r"test_warning_xdist.py::test_with_warning_1 {yellow}PASSED{reset}",
+                    r"test_warning_xdist.py::test_with_warning_2 {yellow}PASSED{reset}",
+                    r"test_warning_xdist.py::test_without_warning {green}PASSED{reset}",
+                ]
+            )
+        )
+
     def test_count(self, many_tests_files, pytester: Pytester) -> None:
         pytester.makeini(
             """