Skip to content

Commit 9947ec3

Browse files
🧪🚑 Pass a Codecov config to the action @ GHA (#12508)
The #11921 update broke uploading coverage of the `main` branch (or any in-repo pushes for that matter) to Codecov 4 months ago. Version 4 requires an upload token to be provided and since there was no configuration for it, the upload was failing. But the step itself was showing up as successful due to `fail_ci_if_error: true` being set. The error is visible in the console output, though. This patch flips the setting to `fail_ci_if_error: false` and sets the Codecov upload token in the config in clear text. The non-secret part allows the PRs uploads to be more stable. Co-authored-by: Ronny Pfannschmidt <[email protected]>
1 parent c8948fc commit 9947ec3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -247,9 +247,8 @@ jobs:
247247
- name: Upload coverage to Codecov
248248
if: "matrix.use_coverage"
249249
uses: codecov/codecov-action@v4
250-
continue-on-error: true
251250
with:
252-
fail_ci_if_error: true
251+
fail_ci_if_error: false
253252
files: ./coverage.xml
254253
verbose: true
255254

codecov.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# reference: https://docs.codecov.io/docs/codecovyml-reference
2+
---
3+
4+
codecov:
5+
token: 1eca3b1f-31a2-4fb8-a8c3-138b441b50a7 #repo token
6+
27
coverage:
38
status:
49
patch: true

0 commit comments

Comments
 (0)