Make it possible for faulthandler to terminate the pytest process on timeout

Author: ogrisel

src/_pytest/faulthandler.py

@@ -16,11 +16,18 @@
 
 
 def pytest_addoption(parser: Parser) -> None:
-    help = (
+    help_timeout = (
         "Dump the traceback of all threads if a test takes "
         "more than TIMEOUT seconds to finish"
     )
-    parser.addini("faulthandler_timeout", help, default=0.0)
+    help_exit_on_timeout = (
+        "Exit the test process if a test takes more than "
+        "faulthandler_timeout seconds to finish"
+    )
+    parser.addini("faulthandler_timeout", help_timeout, default=0.0)
+    parser.addini(
+        "faulthandler_exit_on_timeout", help_exit_on_timeout, type="bool", default=False
+    )
 
 
 def pytest_configure(config: Config) -> None:
@@ -72,14 +79,19 @@ def get_timeout_config_value(config: Config) -> float:
     return float(config.getini("faulthandler_timeout") or 0.0)
 
 
+def get_exit_on_timeout_config_value(config: Config) -> bool:
+    return bool(config.getini("faulthandler_exit_on_timeout"))
+
+
 @pytest.hookimpl(wrapper=True, trylast=True)
 def pytest_runtest_protocol(item: Item) -> Generator[None, object, object]:
     timeout = get_timeout_config_value(item.config)
+    exit_on_timeout = get_exit_on_timeout_config_value(item.config)
     if timeout > 0:
         import faulthandler
 
         stderr = item.config.stash[fault_handler_stderr_fd_key]
-        faulthandler.dump_traceback_later(timeout, file=stderr)
+        faulthandler.dump_traceback_later(timeout, file=stderr, exit=exit_on_timeout)
         try:
             return (yield)
         finally:

testing/test_faulthandler.py

@@ -2,6 +2,7 @@
 from __future__ import annotations
 
 import io
+import os
 import sys
 
 from _pytest.pytester import Pytester
@@ -71,20 +72,15 @@ def test_disabled():
     assert result.ret == 0
 
 
-@pytest.mark.parametrize(
-    "enabled",
-    [
-        pytest.param(
-            True, marks=pytest.mark.skip(reason="sometimes crashes on CI (#7022)")
-        ),
-        False,
-    ],
-)
+@pytest.mark.parametrize("enabled", [True, False])
 def test_timeout(pytester: Pytester, enabled: bool) -> None:
     """Test option to dump tracebacks after a certain timeout.
 
     If faulthandler is disabled, no traceback will be dumped.
     """
+    if enabled and "CI" in os.environ:
+        pytest.xfail(reason="sometimes crashes on CI (#7022)")
+
     pytester.makepyfile(
         """
     import os, time
@@ -110,6 +106,41 @@ def test_timeout():
     assert result.ret == 0
 
 
+@pytest.mark.parametrize("exit_on_timeout", [True, False])
+def test_timeout_and_exit(pytester: Pytester, exit_on_timeout: bool) -> None:
+    """Test option to force exit pytest process after a certain timeout."""
+    if "CI" in os.environ:
+        pytest.xfail(reason="sometimes crashes on CI (#7022)")
+
+    pytester.makepyfile(
+        """
+    import os, time
+    def test_long_sleep_and_raise():
+        time.sleep(1 if "CI" in os.environ else 0.1)
+        raise AssertionError(
+            "This test should have been interrupted before reaching this point."
+        )
+    """
+    )
+    pytester.makeini(
+        f"""
+        [pytest]
+        faulthandler_timeout = 0.01
+        faulthandler_exit_on_timeout = {"true" if exit_on_timeout else "false"}
+        """
+    )
+    result = pytester.runpytest_subprocess()
+    tb_output = "most recent call first"
+    result.stderr.fnmatch_lines([f"*{tb_output}*"])
+    if exit_on_timeout:
+        result.stdout.no_fnmatch_line("*1 failed*")
+        result.stdout.no_fnmatch_line("*AssertionError*")
+    else:
+        result.stdout.fnmatch_lines(["*1 failed*"])
+        result.stdout.fnmatch_lines(["*AssertionError*"])
+    assert result.ret == 1
+
+
 @pytest.mark.parametrize("hook_name", ["pytest_enter_pdb", "pytest_exception_interact"])
 def test_cancel_timeout_on_hook(monkeypatch, hook_name) -> None:
     """Make sure that we are cancelling any scheduled traceback dumping due